#2553 Support source property paths for maps#2653
Merged
filiphr merged 2 commits intomapstruct:mastermapstruct/mapstruct:masterfrom Nov 20, 2021
Merged
#2553 Support source property paths for maps#2653filiphr merged 2 commits intomapstruct:mastermapstruct/mapstruct:masterfrom
filiphr merged 2 commits intomapstruct:mastermapstruct/mapstruct:masterfrom
Conversation
sjaakd
reviewed
Nov 14, 2021
processor/src/main/java/org/mapstruct/ap/internal/model/common/Type.java
Outdated
Show resolved
Hide resolved
sjaakd
approved these changes
Nov 14, 2021
Contributor
sjaakd
left a comment
There was a problem hiding this comment.
Just a tiny remark.. If all testcases pass: LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2553
This PR does some small changes in the way we acquire read accessors. The refactorings in the PR, especially the new methods in the
Typecan open the door for better support for things like JacksonJsonNode,ResultSet, etc.