Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update Dockerfile#3

Open
gyermolenko wants to merge 1 commit intomaligree:mastermaligree/python-ast-explorer:masterfrom
gyermolenko:update_dockerfile27gyermolenko/python-ast-explorer:update_dockerfile27Copy head branch name to clipboard
Open

Update Dockerfile#3
gyermolenko wants to merge 1 commit intomaligree:mastermaligree/python-ast-explorer:masterfrom
gyermolenko:update_dockerfile27gyermolenko/python-ast-explorer:update_dockerfile27Copy head branch name to clipboard

Conversation

@gyermolenko
Copy link

@gyermolenko gyermolenko commented May 13, 2019

  • split layers for caching
  • install npm explicitly since latest alpines do not install it with node
  • do not copy . . (at least at the top of dockerfile) because any change to Dockerfile or readme leads to rebuilding too much stuff
  • fix typo in last CMD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.