Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore: don't sync bindings on forks, as they fail #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2025
Merged

chore: don't sync bindings on forks, as they fail #423

merged 1 commit into from
May 25, 2025

Conversation

makspll
Copy link
Owner

@makspll makspll commented May 25, 2025 •
edited
Loading

Summary

Eventually this can be updated to work on forks (spit out a diff as a comment?) for now just going to skip on forks

@makspll makspll merged commit 4d11149 into main May 25, 2025
21 checks passed
@makspll makspll deleted the chore/dont-sync-bindings-on-forks branch May 25, 2025 11:22
@github-actions GitHub Actions
Copy link
Contributor

🐰 Bencher Report

Branchchore/dont-sync-bindings-on-forks
Testbedlinux-gha

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
component/access Lua📈 view plot
⚠️ NO THRESHOLD		3,521.30 ns
component/access Rhai📈 view plot
⚠️ NO THRESHOLD		6,064.20 ns
component/get Lua📈 view plot
⚠️ NO THRESHOLD		2,174.50 ns
component/get Rhai📈 view plot
⚠️ NO THRESHOLD		4,802.70 ns
conversions/Mut::from📈 view plot
⚠️ NO THRESHOLD		84.32 ns
conversions/Ref::from📈 view plot
⚠️ NO THRESHOLD		80.25 ns
conversions/ScriptValue::List📈 view plot
⚠️ NO THRESHOLD		279.88 ns
conversions/ScriptValue::Map📈 view plot
⚠️ NO THRESHOLD		1,194.60 ns
conversions/ScriptValue::Reference::from_into📈 view plot
⚠️ NO THRESHOLD		25.79 ns
conversions/Val::from_into📈 view plot
⚠️ NO THRESHOLD		228.08 ns
function/call 4 args Lua📈 view plot
⚠️ NO THRESHOLD		1,612.70 ns
function/call 4 args Rhai📈 view plot
⚠️ NO THRESHOLD		1,433.10 ns
function/call Lua📈 view plot
⚠️ NO THRESHOLD		234.82 ns
function/call Rhai📈 view plot
⚠️ NO THRESHOLD		457.92 ns
loading/empty Lua📈 view plot
⚠️ NO THRESHOLD		94,643.00 ns
loading/empty Rhai📈 view plot
⚠️ NO THRESHOLD		1,113,800.00 ns
math/vec mat ops Lua📈 view plot
⚠️ NO THRESHOLD		7,067.80 ns
math/vec mat ops Rhai📈 view plot
⚠️ NO THRESHOLD		5,993.90 ns
query/10 entities Lua📈 view plot
⚠️ NO THRESHOLD		18,261.00 ns
query/10 entities Rhai📈 view plot
⚠️ NO THRESHOLD		20,967.00 ns
query/100 entities Lua📈 view plot
⚠️ NO THRESHOLD		38,241.00 ns
query/100 entities Rhai📈 view plot
⚠️ NO THRESHOLD		33,139.00 ns
query/1000 entities Lua📈 view plot
⚠️ NO THRESHOLD		253,040.00 ns
query/1000 entities Rhai📈 view plot
⚠️ NO THRESHOLD		168,120.00 ns
reflection/10 Lua📈 view plot
⚠️ NO THRESHOLD		5,395.10 ns
reflection/10 Rhai📈 view plot
⚠️ NO THRESHOLD		14,851.00 ns
reflection/100 Lua📈 view plot
⚠️ NO THRESHOLD		45,041.00 ns
reflection/100 Rhai📈 view plot
⚠️ NO THRESHOLD		695,820.00 ns
resource/access Lua📈 view plot
⚠️ NO THRESHOLD		3,104.20 ns
resource/access Rhai📈 view plot
⚠️ NO THRESHOLD		5,369.60 ns
resource/get Lua📈 view plot
⚠️ NO THRESHOLD		1,851.30 ns
resource/get Rhai📈 view plot
⚠️ NO THRESHOLD		4,166.10 ns
🐰 View full continuous benchmarking report in Bencher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@makspll
Morty Proxy This is a proxified and sanitized view of the page, visit original site.