Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

User guide fixes #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thuydotm merged 4 commits into from
Feb 22, 2022
Merged

User guide fixes #665

thuydotm merged 4 commits into from
Feb 22, 2022

Conversation

@DahnJ
Copy link
Contributor

@DahnJ DahnJ commented Feb 21, 2022 •
edited
Loading

I have been going through the user guide and have fixed some smaller problems I found along the way.

I'm happy to make any requested further changes.

Changes

  • 1_Surface: Link for avalanche risk was dead, used another that cites the same angles
  • 2_Proximity: typo
  • 3_Zonal: The path's coordinates appeared to be on a different scale, did not show up on the map and lead to strange results. I also used a better visible color map (not sure if sequential is okay here).
    • The original can be seen in the docs. Below is my result:

image

image

DahnJ added 3 commits February 21, 2022 18:56
@DahnJ
DOC: Fix avalanche risk link
d1d2e90
@DahnJ
DOC: Typo
17cc02c
@DahnJ
FIX: Path in Zonal user guide
df364eb 
- Fix coordinates to be of the same range as terrain
- Clearer visualization
@thuydotm
Copy link
Contributor

thuydotm commented Feb 22, 2022

Thanks @DahnJ. The changes in Surface and Proximity notebook look good to me.

In the Zonal notebook, can you change the range of x and y to: x_range=(-20, 20), and y_range=(-20, 20) so that we can keep zone_df as is, and no need to multiply its xs and ys by 1e6?

I'm ok with using the Hot color map, let's strengthen the line by increase the threshold value in dynspread(), i.e: zones_shaded = dynspread(shade(zones_agg, cmap=Set1), max_px=1, threshold=1)

@DahnJ
Copy link
Contributor Author

DahnJ commented Feb 22, 2022

Thanks @DahnJ. The changes in Surface and Proximity notebook look good to me.

In the Zonal notebook, can you change the range of x and y to: x_range=(-20, 20), and y_range=(-20, 20) so that we can keep zone_df as is, and no need to multiply its xs and ys by 1e6?

I'm ok with using the Hot color map, let's strengthen the line by increase the threshold value in dynspread(), i.e: zones_shaded = dynspread(shade(zones_agg, cmap=Set1), max_px=1, threshold=1)

Thanks for the quick reply. I changed the range and went back to Set1 with threshold=1, it's already nicely visible.

@thuydotm thuydotm merged commit a989a54 into makepath:master Feb 22, 2022
@thuydotm
Copy link
Contributor

thuydotm commented Feb 22, 2022

Thanks for your contribution, this has been merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DahnJ @thuydotm
Morty Proxy This is a proxified and sanitized view of the page, visit original site.