Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@pull
Copy link

@pull pull bot commented Aug 29, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 馃挅 Please sponsor : )

scanny added 14 commits August 25, 2023 13:41
Some version-related changes caused lint and acceptance-test failures
since the last release. Fix those up.
The caller will need to specify the icon height and width when providing
their own custom icon image. Add optional parameters to
`.add_ole_object()` suitable for that purpose and update the
documentation.
At least one autoshape name ('"No" Symbol') contains the double-quote
character which raises an XML exception when it prematurely terminates
the `name="..."` attribute of the autoshape. Escape autoshape basename
to avoid this problem, specifically targetting the double-quote
character.
The `make upload` operation doesn't work anymore, so we need to use
twine instead. This calls for a few modernizations to the distribution
configuration and procedure.
@pull pull bot added the 猡碉笍 pull label Aug 29, 2023
scanny added 15 commits November 2, 2023 14:12
Remove <=9.5.0 constraint which was where `font.getsize()` was removed.
That version has one or more security vulnerabilities not fixed until
10+.
This improves packaging reliability because it prevents tests from
running against the current directory instead of the installed version
of the package.
- Add `pyproject.toml` and gather configuration there. Move `.ruff.toml`
  contents into `pyproject.toml`.
- Add `requirements-test.txt`.
Add type-annotations broadly, but prioritizing interface objects and
methods. Adjust text-width to 100, remove Python 2 support, etc.
#943

Remove mention of a `Px` subtype of `Length` since no such subtype
exists. Turns out a pixel has various sizes on different systems so no
standard unit of measure is possible.
#972

Naive "max + 1" slide-id allocation algorithm assumed that slide-ids
were assigned from bottom up. Apparently some client assigns slide ids
from the top (2,147,483,647) down and the naive algorithm would assign
an invalid slide-id in that case.

Detect when the assigned id is out-of-range and fall-back to a robust
algorithm for assigning a valid id based on a "first unused starting at
bottom" policy.
Accommodate system dates before 1980-01-01.

This should have no effect for users with "normal" system clocks but
allows the package to save files in the unusual case the system clock is
set to a date prior to 1980.
At least one client, perhaps Adobe PDF Converter, produces a PPTX with
JPEG images mapped to the non-existent `image/jpg` MIME-type rather than
the correct `image/jpeg`.

Accept `image/jpg` as an alias for `image/jpeg`, which is consistent
with the behavior of PowerPoint which loads these files without
complaint.
- Move to `pyproject.toml`
- Update support to 3.8+
Indicate availability of type annotations to type-checkers.
Some enum values like `MSO_SHAPE_TYPE.MIXED` are never produced by
`python-pptx` and so were removed during the enum modernization in
commit `01b86e64`. However, in at least one downstream system these
values are referenced even though they can never actually occur.

Replace these "read-only" values to avoid downstream breakage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.