Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Version 8 master update #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 25, 2021
Merged

Version 8 master update #234

merged 17 commits into from
Aug 25, 2021

Conversation

sivaschenko
Copy link
Member

@sivaschenko sivaschenko commented Aug 25, 2021

Version 8 master update

Fixed ImportsFromTestNamespace from lock on group use with trailing comma @fsw
Unit test coverage and fixes for HTML, annotation and less sniffs @eliseacornejo
Moved abstract unit test to autoload-dev @sivaschenko

fsw and others added 17 commits August 20, 2021 12:44
…laration has trailing coma.

If a grouped use statement has a trailing coma like this:
```
use Magento\Something{
  Foo,
  Bar,
};
```
`findNext` on line 59 was returning false and next call was starting to search again from line 1 (`$next + 1`) and this function was looping indefinitely through input tokens.
…-coding-standard-223

[Imported] AC-957: Create unit test for Magento2\Html\HtmlDirectiveSniff check
…-coding-standard-224

[Imported] AC-958: create unit test for Magento2\Annotation checks
…-coding-standard-228

[Imported] Moved abstract unit test to autoload-dev
…-coding-standard-220

[Imported] Fix ImportsFromTestNamespace from lock on group use with trailing comma
…-coding-standard-229

[Imported] AC-939: Create unit test for Magento2\Less\AvoidIdSniff check
…-coding-standard-231

[Imported] Version 8
@sivaschenko
Copy link
Member Author

@magento import pr to magento-commerce/magento-coding-standard

@magento-engcom-team
Copy link
Contributor

@sivaschenko the pull request successfully imported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.