Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Please add support for Rector 2.x #493

Copy link
Copy link
Open
@fooman

Description

@fooman
Issue body actions

Since the magento-coding-standard uses Rector 1.x which in turn requires Phpstan 1.x it is currently not possible to use the latest versions of those tools in conjunction with this package. See also latest versions of bitExpert/phpstan-magento.

I have had a look at the upgrade instructions and extending the range of supported rector versions should be possible without code changes, ie incomposer.json change

"rector/rector": "^1.2.4",

to

"rector/rector": "^1.2.4 || ^2.0.0",

AbstractScopeAwareRector is not used
https://github.com/search?q=repo%3Amagento%2Fmagento-coding-standard%20AbstractScopeAwareRector&type=code

getRuleDefinition usage becomes optional
https://github.com/search?q=repo%3Amagento%2Fmagento-coding-standard%20getRuleDefinition&type=code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.