feat($options): Adds message format function to options #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a message format function to the options object that is passed the JIRA URls array and the selected emoji. The function can return a custom string to format the danger message.
macklinu
approved these changes
Nov 30, 2017
|
Once the master branch build succeeds on Travis, version 1.3.0 should be shipped with this feature. 👍 |
|
@macklinu awesome man! Thank you for the quick response! 💯 |
mcgrathg
pushed a commit
to mcgrathg/danger-plugin-jira-integration
that referenced
this pull request
Apr 13, 2023
# 1.0.0 (2023-04-13) ### Bug Fixes * **jiraIssue:** properly resolve URL ([af099b9](af099b9)) * **node:** support Node 4 ([d89d651](d89d651)) * only add one example JIRA key to warning ([macklinu#47](https://github.com/mcgrathg/danger-plugin-jira-integration/issues/47)) ([56dee38](56dee38)) ### Features * `key` is now optional field ([2acddae](2acddae)) * **$options:** Adds message format function to options ([macklinu#33](https://github.com/mcgrathg/danger-plugin-jira-integration/issues/33)) ([ecfead9](ecfead9)) * **jiraIssue:** add initial implementation ([#1](#1)) ([8638e2f](8638e2f)) * **options:** add location to options ([macklinu#44](https://github.com/mcgrathg/danger-plugin-jira-integration/issues/44)) ([96e6261](96e6261)) * support multiple JIRA issues in PR title ([86c01d0](86c01d0)), closes [macklinu#8](https://github.com/mcgrathg/danger-plugin-jira-integration/issues/8) * support multiple JIRA projects ([macklinu#26](https://github.com/mcgrathg/danger-plugin-jira-integration/issues/26)) ([f0a084f](f0a084f)), closes [macklinu#24](https://github.com/mcgrathg/danger-plugin-jira-integration/issues/24) ### BREAKING CHANGES * **jiraIssue:** this commit introduces functionality ready for a 1.0.0 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to customize the message in danger with a prefix and saw that we couldn't modify the message format. This PR -
Adds a message format function to the options object that is passed the JIRA URls array and the
selected emoji. The function can return a custom string to format the danger message.
Adds a test
Updates the example in the readme