Release 1.22 camille rebase #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good.
CRI-O properly implements the CRI interface, and therefore it is capable of returning the container stats if being asked for. There is no reason to keep CRI-O as a special use case that has to be run with the legacy mode making kubelet using cadvisor on each container. This patch removes the hardcoded assumptions that CRI-O has cannot handle to return containers stats through CRI. Fixes kubernetes#73750 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
We're not guaranteed that the pod passed in has the ContainerSpec we're looking for. With this, we check if the pod has the container spec, and if it doesn't, we try to recover it one more time.
…ceeds 18446744073
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick
3efe7de sidecar: container ordered start/shutdown support
4c01153 sidecar: kubelet: don't bother killing pods when non-sidecars are done
6c8c3b4 sidecar: glog -> klog
cc1cb6f Allow metrics to be retrieved from CRI with CRI-O
137a81e pkg/kubelet: try restoring the container spec if its nil
8251b5f pkg/kubelet: fix 1.14 compat for container restore error text
069517a pkg/kubelet: fix uint64 overflow when elapsed UsageCoreNanoSeconds exceeds 18446744073
6b95d62 do not consider exited containers when calculating nanocores
1ba9ec7 handle case where cpuacct is reset to 0 in a live container # empty
bd36566 remove unnecessary line
03bd351 disable klog for cadvisor.GetDirFsInfo cache miss
drop
428e48e Check next cron schedules in a binary-search fashion
709ab5b wrap table driven tests in t.Run to allow running individual tests (#17)
32a8844 fix missed starting deadline warning never being hit
05e3010 create cronjob controller metrics
ac7b61d add Job scheduled start time annotation
5d4d00a make cronjobController sync period configurable via flag
717d679 cronjob: handle invalid/unschedulable dates
fe822af legacy-cloud-providers/aws: add gp3 pvc support (#28)
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: