Update pkginfo #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression where an exception is raised when setting up
OpenTitan's Python dependencies:
.../.cache/bazel/.../.../external/rules_python/python/pip_install/extract_wheels/lib/wheel.py", line 57, in entry_points
name = "{}-{}".format(metadata.name.replace("-", "_"), metadata.version)
AttributeError: 'NoneType' object has no attribute 'replace'
The issue seems related to the previous version of pkginfo not being able to
parse newer versions of Python package metadata, although the reason why this
started failing all of a sudden has not been root caused.
Signed-off-by: Noah Moroze <noah@opentitan.org>
pqcfox
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
Gave a quick review since I ran into the same problem--LGTM! Verified that this works by applying this commit to $(bazel info output_base)/external/rules_python on earlgrey_es_sival.
Would additionally love to have this merged if possible, since this currently is preventing use of earlgrey_es_sival without manually editing the Bazel output base--thanks so much!
|
I think the issue might be this: https://bugs.launchpad.net/pkginfo/+bug/2058697 |
pamaury
approved these changes
Apr 30, 2025
|
Thanks for taking a look @pamaury and @pqcfox! I think we'll need someone with write access to merge, cc @timothytrippel maybe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression that causes an exception to be raised when building OT Python deps:
The issue seems related to pkginfo not being able to parse newer versions of package metadata, although the reason why this started failing all of a sudden has not been root caused.
To reproduce
In a fresh checkout of OpenTitan's
earlgrey_es_sivalbranch (reproducing might require clearing your Bazel cache, but note that this will break future builds if this fix isn't applied):Now, patch OpenTitan to apply this PR's changes:
The command now completes successfully when re-run:
Actually completing the fix will require updating OpenTitan to declare the newer version of rules_python early in
WORKSPACE(as shown here), or threading it through other transitive dependencies (like crt).