filename should not be empty for TimeBasedRollingFileAppender
#517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimeBasedRollingFileAppender uses `filenamePattern` alone with current date time as opened filename and `filename` field is left empty almost all the time. This brings the problem when it calls `append()` method from the base class FileAppenderBase. The base class FileAppenderBase assumes that `filename` field is the path for opened file. Now this contract is broken. Currently, this will cause log4cplus to print "log4cplus: ERROR file is not open:" when `out` stream is broken. It's confusing and misleading. Users may think that log4cplus tries to open a file with the empty name "". This does not stop here, as long as it persists, more subtle bugs can be introduced. This commit fixes this problem by setting filename to the name of current opened file in `TimeBasedRollingFileAppender::open()` making the contract valid again. Signed-off-by: foxhlchen <foxhlchen@gmail.com>
|
Hm. Shouldn't the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimeBasedRollingFileAppender uses
filenamePatternalone with current date time as opened filename andfilenamefield is left empty almost all the time. This brings the problem when it callsappend()method from the base classFileAppenderBase. The base classFileAppenderBaseassumes thatfilenamefield is the path for opened file. Now this contract is broken.Currently, this will cause log4cplus to print
when
outstream is broken. It's confusing and misleading. Users may think that log4cplus tries to open a file with an empty name"".This does not stop here, as long as it persists, more subtle bugs can be introduced.
This PR fixes this problem by setting
filenameto the name of the currently opened file inTimeBasedRollingFileAppender::open()making the contract valid again.