Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add lodash-es description for ES6 scripts #4035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

alireza-mh
Copy link
Contributor

No description provided.

@jdalton
Copy link
Member

jdalton commented Oct 31, 2018

Hi @alireza-mh!

Could you re-work this against the npm branch and add a note about using lodash-es for it.

@alireza-mh
Copy link
Contributor Author

Hi @jdalton .
thanks for your reply.
Could you be more specific about lodash-es note and working on npm branch?
should i add examples for lodash-es or should i note that it support webpack tree shaking or ... ?
should i replace latest changes of master branch README.md with npm README.md as well?
also what is the benefit of working on npm?

@jdalton
Copy link
Member

jdalton commented Oct 31, 2018

Maybe instead of the ESM syntax snippet you could just add a line that says something like:

Looking for Lodash modules written in ES6 or smaller bundle sizes? Check out lodash-es.

@alireza-mh
Copy link
Contributor Author

alireza-mh commented Oct 31, 2018

@jdalton
i guess this only helps if users use latest versions of webpack.
but it will make sense in the near future.
i will remove imports snippets and add your sentence.
the reason behind writing example was observing lodash library(full library) on projects just for a few functions.

@alireza-mh alireza-mh force-pushed the documentation-readme-es6Import branch from 4f93cba to 7b1fd51 Compare October 31, 2018 16:49
@alireza-mh alireza-mh force-pushed the documentation-readme-es6Import branch from 7b1fd51 to 2c3d98b Compare October 31, 2018 19:27
@alireza-mh alireza-mh changed the title Add ES6 import documentation Add lodash-es description for ES6 scripts Nov 9, 2018
@jdalton jdalton merged commit f822dd8 into lodash:master Nov 15, 2018
@jdalton
Copy link
Member

jdalton commented Nov 15, 2018

Thanks @alireza-mh!

@lock
Copy link

lock bot commented Nov 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.