[GC] Support bidirectional iterator in GCStrategyMap #99316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenm
reviewed
Jul 18, 2024
|
|
||
| /// Insert a new strategy if it is not existed, otherwise do nothing. | ||
| void insert(StringRef Name, std::unique_ptr<GCStrategy> Strategy) { | ||
| auto &S = StrategyMap[Name]; |
There was a problem hiding this comment.
Use insert and check if insert succeeded?
Comment on lines
155
to
+156
| StringMap<std::unique_ptr<GCStrategy>> StrategyMap; | ||
| SmallVector<GCStrategy *, 1> StrategyList; // For bidirectional iterator. |
There was a problem hiding this comment.
Should this be a set vector?
Not really sure why these need indexing by name?
There was a problem hiding this comment.
We need a flat map here:
llvm-project/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
Lines 521 to 525 in 3b78dfa
llvm-project/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
Lines 2469 to 2471 in 3b78dfa
Indexed by name here because GC printers need it (see
OCamlGCPrinter.cpp).
arsenm
reviewed
Jul 19, 2024
| StringMap<std::unique_ptr<GCStrategy>> StrategyMap; | ||
| SmallVector<GCStrategy *, 1> StrategyList; // For bidirectional iterator. |
There was a problem hiding this comment.
How many entries will this have? 1? 2? Can it just get rid of the map?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert this result into a flat-map like class, so
AsmPrintercan iterate over this bidirectionally.