[flang][CMake] CYGWIN: Fix undefined references at link time. #67105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's the right thing to do but needs a rebase. |
While building the source of flang on CYGWIN, the process suddently stopped with lot of "Undefined reference" errors at link time. According to the statement that a shared library can't have undefined references on Windows, I applied the same fix to CYGWIN with this patch.
44fe446 to
be4d868
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building the source of flang on CYGWIN, the process suddently stopped with lot of "Undefined reference" errors at link time.
According to the statement that a shared library can't have undefined references on Windows, I applied the same fix to CYGWIN with this patch.