[LLDB][ELF Core] Support all the Generic (Negative) SI Codes. #140150

Jlalond · May 15, 2025

Recently, I was on an issue that generated a large number of Coredumps, and every time in both LLDB and GDB the signal was just SIGSEGV.

This was frustrating because we would expect a SIGSEGV to have an address, or ideally even bounds. After some digging I found the si_code consistently was -6. With some help from @cdown, we found neither LLDB or GDB supports the si_codes sent from user space.

Excerpted from the sigaction man page.

       For a regular signal, the following list shows the values which
       can be placed in si_code for any signal, along with the reason
       that the signal was generated.

For which I added all of the si_codes to every Linux signal. Now for the Coredump that triggered this whole investigation we get the accurate and now very informative summary.

Additionally from @labath's suggestion to move this to platform and leverage the existing getSiginfo() call on thread, we can now inspect the siginfo struct itself via thread siginfo. Giving us another towards GDB parity on elf cores.

llvmbot · May 15, 2025

@llvm/pr-subscribers-lldb

Author: Jacob Lalonde (Jlalond)

Changes

Recently, I was on an issue that generated a large number of Coredumps, and every time in both LLDB and GDB the signal was just SIGSEGV.

This was frustrating because we would expect a SIGSEGV to have an address, or ideally even bounds. After some digging I found the si_code consistently was -6. With some help from @cdown, we found neither LLDB or GDB supports the si_codes sent from user space.

Excerpted from the sigaction man page.

       For a regular signal, the following list shows the values which
       can be placed in si_code for any signal, along with the reason
       that the signal was generated.

For which I added all of the si_codes to every Linux signal. Now for the Coredump that triggered this whole investigation we get the accurate and now very informative summary.

Importantly, I didn't add an equivalent of siginfo_t to ELFSigInfo, and I think we should open an issue for this to make a (build) platform agnostic struct of siginfo_t. I'll defer to your expertise @labath and @DavidSpickett

Patch is 24.96 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/140150.diff

6 Files Affected:

(modified) lldb/include/lldb/Target/UnixSignals.h (+4-2)
(modified) lldb/source/Plugins/Process/Utility/LinuxSignals.cpp (+88-66)
(modified) lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp (+25-16)
(modified) lldb/source/Plugins/Process/elf-core/ThreadElfCore.h (+23-15)
(modified) lldb/source/Target/UnixSignals.cpp (+9-6)
(modified) lldb/unittests/Signals/UnixSignalsTest.cpp (+9)

diff --git a/lldb/include/lldb/Target/UnixSignals.h b/lldb/include/lldb/Target/UnixSignals.h
index b3605ccefddbe..a1807d69f329b 100644
--- a/lldb/include/lldb/Target/UnixSignals.h
+++ b/lldb/include/lldb/Target/UnixSignals.h
@@ -36,7 +36,9 @@ class UnixSignals {
                        std::optional<int32_t> code = std::nullopt,
                        std::optional<lldb::addr_t> addr = std::nullopt,
                        std::optional<lldb::addr_t> lower = std::nullopt,
-                       std::optional<lldb::addr_t> upper = std::nullopt) const;
+                       std::optional<lldb::addr_t> upper = std::nullopt,
+                       std::optional<uint32_t> pid = std::nullopt,
+                       std::optional<uint32_t> uid = std::nullopt) const;
 
   bool SignalIsValid(int32_t signo) const;
 
@@ -105,7 +107,7 @@ class UnixSignals {
                  llvm::StringRef description,
                  llvm::StringRef alias = llvm::StringRef());
 
-  enum SignalCodePrintOption { None, Address, Bounds };
+  enum SignalCodePrintOption { None, Address, Bounds, Sender };
 
   // Instead of calling this directly, use a ADD_SIGCODE macro to get compile
   // time checks when on the native platform.
diff --git a/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp b/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp
index 9c4fe55147a28..76c32e376eb4b 100644
--- a/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp
+++ b/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp
@@ -38,6 +38,28 @@
 #define ADD_SIGCODE(signal_name, signal_value, code_name, code_value, ...)     \
   AddSignalCode(signal_value, code_value, __VA_ARGS__)
 #endif /* if defined(__linux__) && !defined(__mips__) */
+// See siginfo.h in the Linux Kernel, these codes can be sent for any signal.
+#define ADD_LINUX_SIGNAL(signo, name, ...)                                     \
+  AddSignal(signo, name, __VA_ARGS__);                                         \
+  ADD_SIGCODE(signo, signo, SI_QUEUE, -1, "sent by sigqueue",                  \
+              SignalCodePrintOption::Sender);                                  \
+  ADD_SIGCODE(signo, signo, SI_TIMER, -2, "sent by timer expiration",          \
+              SignalCodePrintOption::Sender);                                  \
+  ADD_SIGCODE(signo, signo, SI_MESGQ, -3,                                      \
+              "sent by real time mesq state change",                           \
+              SignalCodePrintOption::Sender);                                  \
+  ADD_SIGCODE(signo, signo, SI_ASYNCIO, -4, "sent by AIO completion",          \
+              SignalCodePrintOption::Sender);                                  \
+  ADD_SIGCODE(signo, signo, SI_SIGIO, -5, "sent by queued SIGIO",              \
+              SignalCodePrintOption::Sender);                                  \
+  ADD_SIGCODE(signo, signo, SI_TKILL, -6, "sent by tkill system call",         \
+              SignalCodePrintOption::Sender);                                  \
+  ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
+              "sent by execve() killing subsidiary threads",                   \
+              SignalCodePrintOption::Sender);                                  \
+  ADD_SIGCODE(signo, signo, SI_ASYNCNL, -60,                                   \
+              "sent by glibc async name lookup completion",                    \
+              SignalCodePrintOption::Sender);
 
 using namespace lldb_private;
 
@@ -46,13 +68,13 @@ LinuxSignals::LinuxSignals() : UnixSignals() { Reset(); }
 void LinuxSignals::Reset() {
   m_signals.clear();
   // clang-format off
-  //        SIGNO   NAME            SUPPRESS  STOP    NOTIFY  DESCRIPTION
-  //        ======  ==============  ========  ======  ======  ===================================================
-  AddSignal(1,      "SIGHUP",       false,    true,   true,   "hangup");
-  AddSignal(2,      "SIGINT",       true,     true,   true,   "interrupt");
-  AddSignal(3,      "SIGQUIT",      false,    true,   true,   "quit");
+  //               SIGNO   NAME            SUPPRESS  STOP    NOTIFY  DESCRIPTION
+  //               ======  ==============  ========  ======  ======  ===================================================
+  ADD_LINUX_SIGNAL(1,      "SIGHUP",       false,    true,   true,   "hangup");
+  ADD_LINUX_SIGNAL(2,      "SIGINT",       true,     true,   true,   "interrupt");
+  ADD_LINUX_SIGNAL(3,      "SIGQUIT",      false,    true,   true,   "quit");
 
-  AddSignal(4,      "SIGILL",       false,    true,   true,   "illegal instruction");
+  ADD_LINUX_SIGNAL(4,      "SIGILL",       false,    true,   true,   "illegal instruction");
   ADD_SIGCODE(SIGILL, 4, ILL_ILLOPC, 1, "illegal opcode");
   ADD_SIGCODE(SIGILL, 4, ILL_ILLOPN, 2, "illegal operand");
   ADD_SIGCODE(SIGILL, 4, ILL_ILLADR, 3, "illegal addressing mode");
@@ -62,15 +84,15 @@ void LinuxSignals::Reset() {
   ADD_SIGCODE(SIGILL, 4, ILL_COPROC, 7, "coprocessor error");
   ADD_SIGCODE(SIGILL, 4, ILL_BADSTK, 8, "internal stack error");
 
-  AddSignal(5,      "SIGTRAP",      true,     true,   true,   "trace trap (not reset when caught)");
-  AddSignal(6,      "SIGABRT",      false,    true,   true,   "abort()/IOT trap", "SIGIOT");
+  ADD_LINUX_SIGNAL(5,      "SIGTRAP",      true,     true,   true,   "trace trap (not reset when caught)");
+  ADD_LINUX_SIGNAL(6,      "SIGABRT",      false,    true,   true,   "abort()/IOT trap", "SIGIOT");
 
-  AddSignal(7,      "SIGBUS",       false,    true,   true,   "bus error");
+  ADD_LINUX_SIGNAL(7,      "SIGBUS",       false,    true,   true,   "bus error");
   ADD_SIGCODE(SIGBUS, 7, BUS_ADRALN, 1, "illegal alignment");
   ADD_SIGCODE(SIGBUS, 7, BUS_ADRERR, 2, "illegal address");
   ADD_SIGCODE(SIGBUS, 7, BUS_OBJERR, 3, "hardware error");
 
-  AddSignal(8,      "SIGFPE",       false,    true,   true,   "floating point exception");
+  ADD_LINUX_SIGNAL(8,      "SIGFPE",       false,    true,   true,   "floating point exception");
   ADD_SIGCODE(SIGFPE, 8, FPE_INTDIV, 1, "integer divide by zero");
   ADD_SIGCODE(SIGFPE, 8, FPE_INTOVF, 2, "integer overflow");
   ADD_SIGCODE(SIGFPE, 8, FPE_FLTDIV, 3, "floating point divide by zero");
@@ -80,10 +102,10 @@ void LinuxSignals::Reset() {
   ADD_SIGCODE(SIGFPE, 8, FPE_FLTINV, 7, "floating point invalid operation");
   ADD_SIGCODE(SIGFPE, 8, FPE_FLTSUB, 8, "subscript out of range");
 
-  AddSignal(9,      "SIGKILL",      false,    true,   true,   "kill");
-  AddSignal(10,     "SIGUSR1",      false,    true,   true,   "user defined signal 1");
+  ADD_LINUX_SIGNAL(9,      "SIGKILL",      false,    true,   true,   "kill");
+  ADD_LINUX_SIGNAL(10,     "SIGUSR1",      false,    true,   true,   "user defined signal 1");
 
-  AddSignal(11,     "SIGSEGV",      false,    true,   true,   "segmentation violation");
+  ADD_LINUX_SIGNAL(11,     "SIGSEGV",      false,    true,   true,   "segmentation violation");
   ADD_SIGCODE(SIGSEGV, 11, SEGV_MAPERR,  1, "address not mapped to object", SignalCodePrintOption::Address);
   ADD_SIGCODE(SIGSEGV, 11, SEGV_ACCERR,  2, "invalid permissions for mapped object", SignalCodePrintOption::Address);
   ADD_SIGCODE(SIGSEGV, 11, SEGV_BNDERR,  3, "failed address bounds checks", SignalCodePrintOption::Bounds);
@@ -94,58 +116,58 @@ void LinuxSignals::Reset() {
   // codes. One way to get this is via unaligned SIMD loads. Treat it as invalid address.
   ADD_SIGCODE(SIGSEGV, 11, SI_KERNEL, 0x80, "invalid address", SignalCodePrintOption::Address);
 
-  AddSignal(12,     "SIGUSR2",      false,    true,   true,   "user defined signal 2");
-  AddSignal(13,     "SIGPIPE",      false,    true,   true,   "write to pipe with reading end closed");
-  AddSignal(14,     "SIGALRM",      false,    false,  false,  "alarm");
-  AddSignal(15,     "SIGTERM",      false,    true,   true,   "termination requested");
-  AddSignal(16,     "SIGSTKFLT",    false,    true,   true,   "stack fault");
-  AddSignal(17,     "SIGCHLD",      false,    false,  true,   "child status has changed", "SIGCLD");
-  AddSignal(18,     "SIGCONT",      false,    false,  true,   "process continue");
-  AddSignal(19,     "SIGSTOP",      true,     true,   true,   "process stop");
-  AddSignal(20,     "SIGTSTP",      false,    true,   true,   "tty stop");
-  AddSignal(21,     "SIGTTIN",      false,    true,   true,   "background tty read");
-  AddSignal(22,     "SIGTTOU",      false,    true,   true,   "background tty write");
-  AddSignal(23,     "SIGURG",       false,    true,   true,   "urgent data on socket");
-  AddSignal(24,     "SIGXCPU",      false,    true,   true,   "CPU resource exceeded");
-  AddSignal(25,     "SIGXFSZ",      false,    true,   true,   "file size limit exceeded");
-  AddSignal(26,     "SIGVTALRM",    false,    true,   true,   "virtual time alarm");
-  AddSignal(27,     "SIGPROF",      false,    false,  false,  "profiling time alarm");
-  AddSignal(28,     "SIGWINCH",     false,    true,   true,   "window size changes");
-  AddSignal(29,     "SIGIO",        false,    true,   true,   "input/output ready/Pollable event", "SIGPOLL");
-  AddSignal(30,     "SIGPWR",       false,    true,   true,   "power failure");
-  AddSignal(31,     "SIGSYS",       false,    true,   true,   "invalid system call");
-  AddSignal(32,     "SIG32",        false,    false,  false,  "threading library internal signal 1");
-  AddSignal(33,     "SIG33",        false,    false,  false,  "threading library internal signal 2");
-  AddSignal(34,     "SIGRTMIN",     false,    false,  false,  "real time signal 0");
-  AddSignal(35,     "SIGRTMIN+1",   false,    false,  false,  "real time signal 1");
-  AddSignal(36,     "SIGRTMIN+2",   false,    false,  false,  "real time signal 2");
-  AddSignal(37,     "SIGRTMIN+3",   false,    false,  false,  "real time signal 3");
-  AddSignal(38,     "SIGRTMIN+4",   false,    false,  false,  "real time signal 4");
-  AddSignal(39,     "SIGRTMIN+5",   false,    false,  false,  "real time signal 5");
-  AddSignal(40,     "SIGRTMIN+6",   false,    false,  false,  "real time signal 6");
-  AddSignal(41,     "SIGRTMIN+7",   false,    false,  false,  "real time signal 7");
-  AddSignal(42,     "SIGRTMIN+8",   false,    false,  false,  "real time signal 8");
-  AddSignal(43,     "SIGRTMIN+9",   false,    false,  false,  "real time signal 9");
-  AddSignal(44,     "SIGRTMIN+10",  false,    false,  false,  "real time signal 10");
-  AddSignal(45,     "SIGRTMIN+11",  false,    false,  false,  "real time signal 11");
-  AddSignal(46,     "SIGRTMIN+12",  false,    false,  false,  "real time signal 12");
-  AddSignal(47,     "SIGRTMIN+13",  false,    false,  false,  "real time signal 13");
-  AddSignal(48,     "SIGRTMIN+14",  false,    false,  false,  "real time signal 14");
-  AddSignal(49,     "SIGRTMIN+15",  false,    false,  false,  "real time signal 15");
-  AddSignal(50,     "SIGRTMAX-14",  false,    false,  false,  "real time signal 16"); // switching to SIGRTMAX-xxx to match "kill -l" output
-  AddSignal(51,     "SIGRTMAX-13",  false,    false,  false,  "real time signal 17");
-  AddSignal(52,     "SIGRTMAX-12",  false,    false,  false,  "real time signal 18");
-  AddSignal(53,     "SIGRTMAX-11",  false,    false,  false,  "real time signal 19");
-  AddSignal(54,     "SIGRTMAX-10",  false,    false,  false,  "real time signal 20");
-  AddSignal(55,     "SIGRTMAX-9",   false,    false,  false,  "real time signal 21");
-  AddSignal(56,     "SIGRTMAX-8",   false,    false,  false,  "real time signal 22");
-  AddSignal(57,     "SIGRTMAX-7",   false,    false,  false,  "real time signal 23");
-  AddSignal(58,     "SIGRTMAX-6",   false,    false,  false,  "real time signal 24");
-  AddSignal(59,     "SIGRTMAX-5",   false,    false,  false,  "real time signal 25");
-  AddSignal(60,     "SIGRTMAX-4",   false,    false,  false,  "real time signal 26");
-  AddSignal(61,     "SIGRTMAX-3",   false,    false,  false,  "real time signal 27");
-  AddSignal(62,     "SIGRTMAX-2",   false,    false,  false,  "real time signal 28");
-  AddSignal(63,     "SIGRTMAX-1",   false,    false,  false,  "real time signal 29");
-  AddSignal(64,     "SIGRTMAX",     false,    false,  false,  "real time signal 30");
+  ADD_LINUX_SIGNAL(12,     "SIGUSR2",      false,    true,   true,   "user defined signal 2");
+  ADD_LINUX_SIGNAL(13,     "SIGPIPE",      false,    true,   true,   "write to pipe with reading end closed");
+  ADD_LINUX_SIGNAL(14,     "SIGALRM",      false,    false,  false,  "alarm");
+  ADD_LINUX_SIGNAL(15,     "SIGTERM",      false,    true,   true,   "termination requested");
+  ADD_LINUX_SIGNAL(16,     "SIGSTKFLT",    false,    true,   true,   "stack fault");
+  ADD_LINUX_SIGNAL(17,     "SIGCHLD",      false,    false,  true,   "child status has changed", "SIGCLD");
+  ADD_LINUX_SIGNAL(18,     "SIGCONT",      false,    false,  true,   "process continue");
+  ADD_LINUX_SIGNAL(19,     "SIGSTOP",      true,     true,   true,   "process stop");
+  ADD_LINUX_SIGNAL(20,     "SIGTSTP",      false,    true,   true,   "tty stop");
+  ADD_LINUX_SIGNAL(21,     "SIGTTIN",      false,    true,   true,   "background tty read");
+  ADD_LINUX_SIGNAL(22,     "SIGTTOU",      false,    true,   true,   "background tty write");
+  ADD_LINUX_SIGNAL(23,     "SIGURG",       false,    true,   true,   "urgent data on socket");
+  ADD_LINUX_SIGNAL(24,     "SIGXCPU",      false,    true,   true,   "CPU resource exceeded");
+  ADD_LINUX_SIGNAL(25,     "SIGXFSZ",      false,    true,   true,   "file size limit exceeded");
+  ADD_LINUX_SIGNAL(26,     "SIGVTALRM",    false,    true,   true,   "virtual time alarm");
+  ADD_LINUX_SIGNAL(27,     "SIGPROF",      false,    false,  false,  "profiling time alarm");
+  ADD_LINUX_SIGNAL(28,     "SIGWINCH",     false,    true,   true,   "window size changes");
+  ADD_LINUX_SIGNAL(29,     "SIGIO",        false,    true,   true,   "input/output ready/Pollable event", "SIGPOLL");
+  ADD_LINUX_SIGNAL(30,     "SIGPWR",       false,    true,   true,   "power failure");
+  ADD_LINUX_SIGNAL(31,     "SIGSYS",       false,    true,   true,   "invalid system call");
+  ADD_LINUX_SIGNAL(32,     "SIG32",        false,    false,  false,  "threading library internal signal 1");
+  ADD_LINUX_SIGNAL(33,     "SIG33",        false,    false,  false,  "threading library internal signal 2");
+  ADD_LINUX_SIGNAL(34,     "SIGRTMIN",     false,    false,  false,  "real time signal 0");
+  ADD_LINUX_SIGNAL(35,     "SIGRTMIN+1",   false,    false,  false,  "real time signal 1");
+  ADD_LINUX_SIGNAL(36,     "SIGRTMIN+2",   false,    false,  false,  "real time signal 2");
+  ADD_LINUX_SIGNAL(37,     "SIGRTMIN+3",   false,    false,  false,  "real time signal 3");
+  ADD_LINUX_SIGNAL(38,     "SIGRTMIN+4",   false,    false,  false,  "real time signal 4");
+  ADD_LINUX_SIGNAL(39,     "SIGRTMIN+5",   false,    false,  false,  "real time signal 5");
+  ADD_LINUX_SIGNAL(40,     "SIGRTMIN+6",   false,    false,  false,  "real time signal 6");
+  ADD_LINUX_SIGNAL(41,     "SIGRTMIN+7",   false,    false,  false,  "real time signal 7");
+  ADD_LINUX_SIGNAL(42,     "SIGRTMIN+8",   false,    false,  false,  "real time signal 8");
+  ADD_LINUX_SIGNAL(43,     "SIGRTMIN+9",   false,    false,  false,  "real time signal 9");
+  ADD_LINUX_SIGNAL(44,     "SIGRTMIN+10",  false,    false,  false,  "real time signal 10");
+  ADD_LINUX_SIGNAL(45,     "SIGRTMIN+11",  false,    false,  false,  "real time signal 11");
+  ADD_LINUX_SIGNAL(46,     "SIGRTMIN+12",  false,    false,  false,  "real time signal 12");
+  ADD_LINUX_SIGNAL(47,     "SIGRTMIN+13",  false,    false,  false,  "real time signal 13");
+  ADD_LINUX_SIGNAL(48,     "SIGRTMIN+14",  false,    false,  false,  "real time signal 14");
+  ADD_LINUX_SIGNAL(49,     "SIGRTMIN+15",  false,    false,  false,  "real time signal 15");
+  ADD_LINUX_SIGNAL(50,     "SIGRTMAX-14",  false,    false,  false,  "real time signal 16"); // switching to SIGRTMAX-xxx to match "kill -l" output
+  ADD_LINUX_SIGNAL(51,     "SIGRTMAX-13",  false,    false,  false,  "real time signal 17");
+  ADD_LINUX_SIGNAL(52,     "SIGRTMAX-12",  false,    false,  false,  "real time signal 18");
+  ADD_LINUX_SIGNAL(53,     "SIGRTMAX-11",  false,    false,  false,  "real time signal 19");
+  ADD_LINUX_SIGNAL(54,     "SIGRTMAX-10",  false,    false,  false,  "real time signal 20");
+  ADD_LINUX_SIGNAL(55,     "SIGRTMAX-9",   false,    false,  false,  "real time signal 21");
+  ADD_LINUX_SIGNAL(56,     "SIGRTMAX-8",   false,    false,  false,  "real time signal 22");
+  ADD_LINUX_SIGNAL(57,     "SIGRTMAX-7",   false,    false,  false,  "real time signal 23");
+  ADD_LINUX_SIGNAL(58,     "SIGRTMAX-6",   false,    false,  false,  "real time signal 24");
+  ADD_LINUX_SIGNAL(59,     "SIGRTMAX-5",   false,    false,  false,  "real time signal 25");
+  ADD_LINUX_SIGNAL(60,     "SIGRTMAX-4",   false,    false,  false,  "real time signal 26");
+  ADD_LINUX_SIGNAL(61,     "SIGRTMAX-3",   false,    false,  false,  "real time signal 27");
+  ADD_LINUX_SIGNAL(62,     "SIGRTMAX-2",   false,    false,  false,  "real time signal 28");
+  ADD_LINUX_SIGNAL(63,     "SIGRTMAX-1",   false,    false,  false,  "real time signal 29");
+  ADD_LINUX_SIGNAL(64,     "SIGRTMAX",     false,    false,  false,  "real time signal 30");
   // clang-format on
 }
diff --git a/lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp b/lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp
index a0cd0ee5025bd..907e009bc7b80 100644
--- a/lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp
+++ b/lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp
@@ -584,22 +584,26 @@ Status ELFLinuxSigInfo::Parse(const DataExtractor &data, const ArchSpec &arch,
   // 64b ELF have a 4 byte pad.
   if (data.GetAddressByteSize() == 8)
     offset += 4;
-  // Not every stop signal has a valid address, but that will get resolved in
-  // the unix_signals.GetSignalDescription() call below.
-  if (unix_signals.GetShouldStop(si_signo)) {
+
+  if (si_code < 0) {
+    sifields.kill.pid = data.GetU32(&offset);
+    sifields.kill.uid = data.GetU32(&offset);
+  } else if (unix_signals.GetShouldStop(si_signo)) {
+    // Not every stop signal has a valid address, but that will get resolved in
+    // the unix_signals.GetSignalDescription() call below.
     // Instead of memcpy we call all these individually as the extractor will
     // handle endianness for us.
-    sigfault.si_addr = data.GetAddress(&offset);
-    sigfault.si_addr_lsb = data.GetU16(&offset);
-    if (data.GetByteSize() - offset >= sizeof(sigfault.bounds)) {
-      sigfault.bounds._addr_bnd._lower = data.GetAddress(&offset);
-      sigfault.bounds._addr_bnd._upper = data.GetAddress(&offset);
-      sigfault.bounds._pkey = data.GetU32(&offset);
+    sifields.sigfault.si_addr = data.GetAddress(&offset);
+    sifields.sigfault.si_addr_lsb = data.GetU16(&offset);
+    if (data.GetByteSize() - offset >= sizeof(sifields.sigfault.bounds)) {
+      sifields.sigfault.bounds._addr_bnd._lower = data.GetAddress(&offset);
+      sifields.sigfault.bounds._addr_bnd._upper = data.GetAddress(&offset);
+      sifields.sigfault.bounds._pkey = data.GetU32(&offset);
     } else {
       // Set these to 0 so we don't use bogus data for the description.
-      sigfault.bounds._addr_bnd._lower = 0;
-      sigfault.bounds._addr_bnd._upper = 0;
-      sigfault.bounds._pkey = 0;
+      sifields.sigfault.bounds._addr_bnd._lower = 0;
+      sifields.sigfault.bounds._addr_bnd._upper = 0;
+      sifields.sigfault.bounds._pkey = 0;
     }
   }
 
@@ -609,13 +613,18 @@ Status ELFLinuxSigInfo::Parse(const DataExtractor &data, const ArchSpec &arch,
 std::string ELFLinuxSigInfo::GetDescription(
     const lldb_private::UnixSignals &unix_signals) const {
   if (unix_signals.GetShouldStop(si_signo) && note_type == eNT_SIGINFO) {
-    if (sigfault.bounds._addr_bnd._upper != 0)
+    if (si_code < 0)
+      return unix_signals.GetSignalDescription(
+          si_signo, si_code, std::nullopt, std::nullopt, std::nullopt,
+          sifields.kill.pid, sifields.kill.uid);
+    else if (sifields.sigfault.bounds._addr_bnd._upper != 0)
       return unix_signals.GetSignalDescription(
-          si_signo, si_code, sigfault.si_addr, sigfault.bounds._addr_bnd._lower,
-          sigfault.bounds._addr_bnd._upper);
+          si_signo, si_code, sifields.sigfault.si_addr,
+          sifields.sigfault.bounds._addr_bnd._lower,
+          sifie...
[truncated]

youngd007 · May 15, 2025

lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp

+    sifields.kill.pid = data.GetU32(&offset);
+    sifields.kill.uid = data.GetU32(&offset);


Are these populating to the same ints if the offset is the same into the data object/struct?

No, the data extractor will increment the offset for each call, so the first call will take the first 0-4 bytes, and the second call the next 4-8 bytes.

Jlalond · May 15, 2025

lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp

-  // the unix_signals.GetSignalDescription() call below.
-  if (unix_signals.GetShouldStop(si_signo)) {
+
+  if (si_code < 0) {


So this check is my primary concern with my own code. In the Linux source I linked they define user space as <0, and I followed suite here. I would ideally like to make this a static function on LinuxSignals, but wanted to get feedback on how we want to implement this.

labath

I like this functionality, but I'm not overall very happy with how this code ended up assuming a certain siginfo layout (which is likely going to be wrong for non-linux OSes).

Ideally, I think this should be the responsibility of the platform class so that it can be customized for each OS and so that it's available to non-corefile processes as well. The platform class already knows the correct layout for the given architecture (PlatformLinux::GetSiginfoType) and in the case of a live process we can use the thread siginfo command to dump the contents of the siginfo_t structure. I think it would be reasonable to add a function that takes the raw bytes and gives you a short summary of the signal (which you can then put in the stop description).

Jlalond · May 16, 2025

@labath

I refactored to the best of my ability the signal parsing. Thankfully even getting thread siginfo working.

However I'm unhappy with how I'm handling the ValueObject in the Linux Signals, I couldn't find an easy way to make this into some generic siginfo linux type, so I'm directly accessing members. While it's good I made a better way of doing this, I feel this is worse in terms of safety due to having to explore the ValueObject hierarchy. Any advice here?

Secondly, while testing I found the layout in the valueobject differs to the siginfo_t on my machine in some subtle ways. Even if the Core was generated on my machine.

labath

I think this is a pretty good attempt. Thanks for trying it out.

My main problem with it is that I still think that this functionality should be in the platform class. I have a couple of reasons for that:

the platform class is the one who defines the layout of the type, so it makes sense for it to be interpreting it as well
this won't work with the way that live processes work now. Linux process will not get a LinuxSignals object -- they get a GDBRemoteSignals instance instead. It should be easier to make live processes work if the interpretation is in the platform class (and the signals object just provides the data).
UnixSignals are used in lldb-server and ValueObject is too high-level for it. Having UnixSignals depend on that might explode the dependency tree of lldb-server

Basically, what I'm imagining is to take the function you've written here (GetSignalDescriptionFromSiginfo) and put that into the platform class instead -- plus or minus some interface tweaks (I'd consider having the function return a full-blown StopInfo object instead of just a description).

labath · May 20, 2025

However I'm unhappy with how I'm handling the ValueObject in the Linux Signals, I couldn't find an easy way to make this into some generic siginfo linux type, so I'm directly accessing members. While it's good I made a better way of doing this, I feel this is worse in terms of safety due to having to explore the ValueObject hierarchy. Any advice here?

I don't have a silver bullet. I think it of as a price to pay for being generic. Moving to the platform class should help as then the same piece of code will be responsible for creating the type and traversing it. What might help is to change the interface so that instead of a finished ValueObject, the platform method gets just the raw data (in whatever form is suitable) -- and then it creates the value object internally. That would help because then there would be no doubt that the value/type you get here is the one you created a couple of lines above -- and then I think you could freely access the members without being too defensive. If the data buffer is of the right size, there's no reason why getting any of the siginfo members should fail. I say "might" because this may require some refactoring of Thread::GetSiginfo value to avoid duplicating its implementation -- and I don't know how hard that would be.

Secondly, while testing I found the layout in the valueobject differs to the siginfo_t on my machine in some subtle ways. Even if the Core was generated on my machine.

That's definitely possible, but I think that just means the platform definition of the struct has a bug somewhere -- maybe it's missing some alignas annotation? The good thing about centralizing this is that the bug only needs to be fixed once. If you feel so inclined, you could try to add something similar to the UnixSignals tests, where we validate the hardcoded constants against the host definition -- if the host definition is available.

Jlalond · May 20, 2025

@labath I think I misunderstand the vision you're trying to get at. Are you suggesting we have Platform determine the Signal description and the ProcessElfThread would call out to the platform_sp for it?

labath · May 20, 2025

Correct.

… then parse that in thlinux signals

…gnal differs from the linux definition

Jlalond · May 22, 2025

@labath So I moved the behavior to platform, I agree it's cleaner this way. One area that I couldn't decide is if the ValueObj should be constructed in Platform or not. Because Thread calls out to platform I just decided to call the existing method, but I wanted your feedback on this because it does feel somewhat split purpose. It might make sense to move the code into platform and have thread call platform to create the SP, the issue is that the value object needs a target reference.

labath

One area that I couldn't decide is if the ValueObj should be constructed in Platform or not. Because Thread calls out to platform I just decided to call the existing method, but I wanted your feedback on this because it does feel somewhat split purpose. It might make sense to move the code into platform and have thread call platform to create the SP, the issue is that the value object needs a target reference.

I'm not sure about that myself. I think it would make sense, but it's hard to say without seeing how it would look like. I don't think it needs to be done here, but I would encourage you to give it a shot afterwards.

Now for tests. The tests for the UnixSignals part are great, but I'm not sure if there's a test for the end-to-end flow. It possible this automatically code is tested by one of the existing core file. Could you check if anything breaks if you e.g. change GetDescriptionFromSiginfo to return an empty string? If it does, then it's probably fine. If not, could you check if one of our existing core files has the siginfo stuff we'd need to write a test for this?

labath · May 23, 2025

lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp

+  int code = siginfo_sp->GetChildMemberWithName("si_code")->GetValueAsSigned(0);
+  int signo =
+      siginfo_sp->GetChildMemberWithName("si_signo")->GetValueAsSigned(-1);
+  // si_code = 0 is SI_NOINFO, we just want the description with nothing


I don't think it is. The only reference I can find is https://github.com/torvalds/linux/blob/94305e83eccb3120c921cd3a015cd74731140bac/arch/sparc/include/uapi/asm/siginfo.h#L14 and there it's set to 32767.

0 is SI_USER, which is used by kill, so in theory uid/pid should be set. However, it's also used as a default value, so maybe not printing the uid/pid in this case is actually correct:
https://github.com/torvalds/linux/blob/94305e83eccb3120c921cd3a015cd74731140bac/kernel/signal.c#L589-L599

I'm not sure where I got this information, but it shouldn't matter because the code is not defined. Good eye.

labath · May 23, 2025

lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp

+  if (siginfo_description.empty())
+    return StopInfo::CreateStopReasonWithSignal(
+        thread, signo_sp->GetValueAsUnsigned(-1));
+  else


https://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return

Jlalond · May 23, 2025

Now for tests. The tests for the UnixSignals part are great, but I'm not sure if there's a test for the end-to-end flow. It possible this automatically code is tested by one of the existing core file. Could you check if anything breaks if you e.g. change GetDescriptionFromSiginfo to return an empty string? If it does, then it's probably fine. If not, could you check if one of our existing core files has the siginfo stuff we'd need to write a test for this?

Yep! I broke basically every core test on my 5th commit, plenty of shell tests that cover this and I ensured I maintained the existing behavior.

labath

Okay, looks good then. Thanks for your patience.

DavidSpickett · May 27, 2025

This looks like a good candidate for a release note.

You can add that here or in a follow up PR.

Jlalond · May 27, 2025

@DavidSpickett I'll make a follow up patch!

felipepiovezan · May 27, 2025

There's a very good chance this is breaking a lot of tests on mac: https://green.lab.llvm.org/job/as-lldb-cmake/26580/console

Could you have a look? The only other commit there is a table gen warning fix

Jlalond · May 27, 2025

@felipepiovezan I am indeed the problem here. I'm confused how they're passing on Linux but failing on Mac. I'll investigate.

JDevlieghere · May 27, 2025

@felipepiovezan I am indeed the problem here. I'm confused how they're passing on Linux but failing on Mac. I'll investigate.

If you think this might take a while, can we revert this in the meantime?

…#140150)" This reverts commit ff7bb17.

#141645) Reverts #140150 Broke the Darwin tests, but they pass on Linux. Reverting to make the build healthy while I investigate

Jlalond · May 27, 2025

@JDevlieghere reverted while I investigate

…) SI Codes." (#141645) Reverts llvm/llvm-project#140150 Broke the Darwin tests, but they pass on Linux. Reverting to make the build healthy while I investigate

petrhosek · May 27, 2025

We also saw a build failure on our Linux builders:

/b/s/w/ir/x/w/rc/cxx-rbew3r8iaxj/reclient-cxx-wrapper.sh /b/s/w/ir/x/w/cipd/clang/bin/clang++ --sysroot=/b/s/w/ir/x/w/cipd/linux -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -DLIBXML_STATIC -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/s/w/ir/x/w/llvm_build/tools/lldb/source/Plugins/Process/Utility -I/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility -I/b/s/w/ir/x/w/llvm-llvm-project/lldb/include -I/b/s/w/ir/x/w/llvm_build/tools/lldb/include -I/b/s/w/ir/x/w/llvm_build/include -I/b/s/w/ir/x/w/llvm-llvm-project/llvm/include -I/b/s/w/ir/x/w/install-cpython-x86_64-linux-gnu/include/python3.11 -I/b/s/w/ir/x/w/llvm-llvm-project/llvm/../clang/include -I/b/s/w/ir/x/w/llvm_build/tools/lldb/../clang/include -I/b/s/w/ir/x/w/llvm-llvm-project/lldb/source -I/b/s/w/ir/x/w/llvm_build/tools/lldb/source -isystem /b/s/w/ir/x/w/install-zlib-x86_64-linux-gnu/include -isystem /b/s/w/ir/x/w/install-zstd-x86_64-linux-gnu/include -isystem /b/s/w/ir/x/w/install-libxml2-x86_64-linux-gnu/include/libxml2 -isystem /b/s/w/ir/x/w/install-libedit-x86_64-linux-gnu/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wno-unnecessary-virtual-specifier -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-vla-extension -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -MD -MT tools/lldb/source/Plugins/Process/Utility/CMakeFiles/lldbPluginProcessUtility.dir/LinuxSignals.cpp.o -MF tools/lldb/source/Plugins/Process/Utility/CMakeFiles/lldbPluginProcessUtility.dir/LinuxSignals.cpp.o.d -o tools/lldb/source/Plugins/Process/Utility/CMakeFiles/lldbPluginProcessUtility.dir/LinuxSignals.cpp.o -c /b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:73:3: error: use of undeclared identifier 'SI_DETHREAD'; did you mean 'SIGEV_THREAD'?
   73 |   ADD_LINUX_SIGNAL(1,      "SIGHUP",       false,    true,   true,   "hangup");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |                             ^~~~~~~~~~~
/b/s/w/ir/x/w/cipd/linux/usr/include/x86_64-linux-gnu/bits/siginfo.h:340:3: note: 'SIGEV_THREAD' declared here
  340 |   SIGEV_THREAD,                 /* Deliver via thread creation.  */
      |   ^
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:73:3: error: static assertion failed due to requirement 'SIGEV_THREAD == -7': Value mismatch for signal code SI_DETHREAD
   73 |   ADD_LINUX_SIGNAL(1,      "SIGHUP",       false,    true,   true,   "hangup");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:17: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ^~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:73:3: note: expression evaluates to '2 == -7'
   73 |   ADD_LINUX_SIGNAL(1,      "SIGHUP",       false,    true,   true,   "hangup");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:3: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:27: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ~~~~~~~~~~^~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:74:3: error: use of undeclared identifier 'SI_DETHREAD'; did you mean 'SIGEV_THREAD'?
   74 |   ADD_LINUX_SIGNAL(2,      "SIGINT",       true,     true,   true,   "interrupt");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |                             ^~~~~~~~~~~
/b/s/w/ir/x/w/cipd/linux/usr/include/x86_64-linux-gnu/bits/siginfo.h:340:3: note: 'SIGEV_THREAD' declared here
  340 |   SIGEV_THREAD,                 /* Deliver via thread creation.  */
      |   ^
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:74:3: error: static assertion failed due to requirement 'SIGEV_THREAD == -7': Value mismatch for signal code SI_DETHREAD
   74 |   ADD_LINUX_SIGNAL(2,      "SIGINT",       true,     true,   true,   "interrupt");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:17: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ^~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:74:3: note: expression evaluates to '2 == -7'
   74 |   ADD_LINUX_SIGNAL(2,      "SIGINT",       true,     true,   true,   "interrupt");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:3: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:27: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ~~~~~~~~~~^~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:75:3: error: use of undeclared identifier 'SI_DETHREAD'; did you mean 'SIGEV_THREAD'?
   75 |   ADD_LINUX_SIGNAL(3,      "SIGQUIT",      false,    true,   true,   "quit");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |                             ^~~~~~~~~~~
/b/s/w/ir/x/w/cipd/linux/usr/include/x86_64-linux-gnu/bits/siginfo.h:340:3: note: 'SIGEV_THREAD' declared here
  340 |   SIGEV_THREAD,                 /* Deliver via thread creation.  */
      |   ^
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:75:3: error: static assertion failed due to requirement 'SIGEV_THREAD == -7': Value mismatch for signal code SI_DETHREAD
   75 |   ADD_LINUX_SIGNAL(3,      "SIGQUIT",      false,    true,   true,   "quit");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:17: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ^~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:75:3: note: expression evaluates to '2 == -7'
   75 |   ADD_LINUX_SIGNAL(3,      "SIGQUIT",      false,    true,   true,   "quit");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:3: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:27: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ~~~~~~~~~~^~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:77:3: error: use of undeclared identifier 'SI_DETHREAD'; did you mean 'SIGEV_THREAD'?
   77 |   ADD_LINUX_SIGNAL(4,      "SIGILL",       false,    true,   true,   "illegal instruction");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |                             ^~~~~~~~~~~
/b/s/w/ir/x/w/cipd/linux/usr/include/x86_64-linux-gnu/bits/siginfo.h:340:3: note: 'SIGEV_THREAD' declared here
  340 |   SIGEV_THREAD,                 /* Deliver via thread creation.  */
      |   ^
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:77:3: error: static assertion failed due to requirement 'SIGEV_THREAD == -7': Value mismatch for signal code SI_DETHREAD
   77 |   ADD_LINUX_SIGNAL(4,      "SIGILL",       false,    true,   true,   "illegal instruction");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:17: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ^~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:77:3: note: expression evaluates to '2 == -7'
   77 |   ADD_LINUX_SIGNAL(4,      "SIGILL",       false,    true,   true,   "illegal instruction");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:3: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:27: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ~~~~~~~~~~^~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:87:3: error: use of undeclared identifier 'SI_DETHREAD'; did you mean 'SIGEV_THREAD'?
   87 |   ADD_LINUX_SIGNAL(5,      "SIGTRAP",      true,     true,   true,   "trace trap (not reset when caught)");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |                             ^~~~~~~~~~~
/b/s/w/ir/x/w/cipd/linux/usr/include/x86_64-linux-gnu/bits/siginfo.h:340:3: note: 'SIGEV_THREAD' declared here
  340 |   SIGEV_THREAD,                 /* Deliver via thread creation.  */
      |   ^
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:87:3: error: static assertion failed due to requirement 'SIGEV_THREAD == -7': Value mismatch for signal code SI_DETHREAD
   87 |   ADD_LINUX_SIGNAL(5,      "SIGTRAP",      true,     true,   true,   "trace trap (not reset when caught)");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:17: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ^~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:87:3: note: expression evaluates to '2 == -7'
   87 |   ADD_LINUX_SIGNAL(5,      "SIGTRAP",      true,     true,   true,   "trace trap (not reset when caught)");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:3: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:27: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ~~~~~~~~~~^~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:88:3: error: use of undeclared identifier 'SI_DETHREAD'; did you mean 'SIGEV_THREAD'?
   88 |   ADD_LINUX_SIGNAL(6,      "SIGABRT",      false,    true,   true,   "abort()/IOT trap", "SIGIOT");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |                             ^~~~~~~~~~~
/b/s/w/ir/x/w/cipd/linux/usr/include/x86_64-linux-gnu/bits/siginfo.h:340:3: note: 'SIGEV_THREAD' declared here
  340 |   SIGEV_THREAD,                 /* Deliver via thread creation.  */
      |   ^
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:88:3: error: static assertion failed due to requirement 'SIGEV_THREAD == -7': Value mismatch for signal code SI_DETHREAD
   88 |   ADD_LINUX_SIGNAL(6,      "SIGABRT",      false,    true,   true,   "abort()/IOT trap", "SIGIOT");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:17: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ^~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:88:3: note: expression evaluates to '2 == -7'
   88 |   ADD_LINUX_SIGNAL(6,      "SIGABRT",      false,    true,   true,   "abort()/IOT trap", "SIGIOT");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:3: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:27: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ~~~~~~~~~~^~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:90:3: error: use of undeclared identifier 'SI_DETHREAD'; did you mean 'SIGEV_THREAD'?
   90 |   ADD_LINUX_SIGNAL(7,      "SIGBUS",       false,    true,   true,   "bus error");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |                             ^~~~~~~~~~~
/b/s/w/ir/x/w/cipd/linux/usr/include/x86_64-linux-gnu/bits/siginfo.h:340:3: note: 'SIGEV_THREAD' declared here
  340 |   SIGEV_THREAD,                 /* Deliver via thread creation.  */
      |   ^
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:90:3: error: static assertion failed due to requirement 'SIGEV_THREAD == -7': Value mismatch for signal code SI_DETHREAD
   90 |   ADD_LINUX_SIGNAL(7,      "SIGBUS",       false,    true,   true,   "bus error");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:17: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ^~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:90:3: note: expression evaluates to '2 == -7'
   90 |   ADD_LINUX_SIGNAL(7,      "SIGBUS",       false,    true,   true,   "bus error");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:3: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:27: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ~~~~~~~~~~^~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:95:3: error: use of undeclared identifier 'SI_DETHREAD'; did you mean 'SIGEV_THREAD'?
   95 |   ADD_LINUX_SIGNAL(8,      "SIGFPE",       false,    true,   true,   "floating point exception");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |                             ^~~~~~~~~~~
/b/s/w/ir/x/w/cipd/linux/usr/include/x86_64-linux-gnu/bits/siginfo.h:340:3: note: 'SIGEV_THREAD' declared here
  340 |   SIGEV_THREAD,                 /* Deliver via thread creation.  */
      |   ^
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:95:3: error: static assertion failed due to requirement 'SIGEV_THREAD == -7': Value mismatch for signal code SI_DETHREAD
   95 |   ADD_LINUX_SIGNAL(8,      "SIGFPE",       false,    true,   true,   "floating point exception");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:17: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ^~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:95:3: note: expression evaluates to '2 == -7'
   95 |   ADD_LINUX_SIGNAL(8,      "SIGFPE",       false,    true,   true,   "floating point exception");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:3: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:27: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ~~~~~~~~~~^~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:105:3: error: use of undeclared identifier 'SI_DETHREAD'; did you mean 'SIGEV_THREAD'?
  105 |   ADD_LINUX_SIGNAL(9,      "SIGKILL",      false,    true,   true,   "kill");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |                             ^~~~~~~~~~~
/b/s/w/ir/x/w/cipd/linux/usr/include/x86_64-linux-gnu/bits/siginfo.h:340:3: note: 'SIGEV_THREAD' declared here
  340 |   SIGEV_THREAD,                 /* Deliver via thread creation.  */
      |   ^
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:105:3: error: static assertion failed due to requirement 'SIGEV_THREAD == -7': Value mismatch for signal code SI_DETHREAD
  105 |   ADD_LINUX_SIGNAL(9,      "SIGKILL",      false,    true,   true,   "kill");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:17: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ^~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:105:3: note: expression evaluates to '2 == -7'
  105 |   ADD_LINUX_SIGNAL(9,      "SIGKILL",      false,    true,   true,   "kill");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:3: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |               "sent by execve() killing subsidiary threads",                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |               SignalCodePrintOption::Sender);                                  \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:34:27: note: expanded from macro 'ADD_SIGCODE'
   34 |   static_assert(code_name == code_value,                                       \
      |                 ~~~~~~~~~~^~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:106:3: error: use of undeclared identifier 'SI_DETHREAD'; did you mean 'SIGEV_THREAD'?
  106 |   ADD_LINUX_SIGNAL(10,     "SIGUSR1",      false,    true,   true,   "user defined signal 1");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:57:29: note: expanded from macro 'ADD_LINUX_SIGNAL'
   57 |   ADD_SIGCODE(signo, signo, SI_DETHREAD, -7,                                   \
      |                             ^~~~~~~~~~~
/b/s/w/ir/x/w/cipd/linux/usr/include/x86_64-linux-gnu/bits/siginfo.h:340:3: note: 'SIGEV_THREAD' declared here
  340 |   SIGEV_THREAD,                 /* Deliver via thread creation.  */
      |   ^

Jlalond · May 27, 2025

@petrhosek Hey Petr, can you provide more information? For Linux environments, SI_DETHREAD should be present. The commit for this signal specifically is 13 years old, @DavidSpickett do you have any insight as to why this is happening?

SI_DETHREAD

(Updated with an actually useful Linux line number)

petrhosek · May 27, 2025

@petrhosek Hey Petr, can you provide more information? For Linux environments, SI_DETHREAD should be present. The commit for this signal specifically is 13 years old, @DavidSpickett do you have any insight as to why this is happening?

SI_DETHREAD

(Updated with an actually useful Linux line number)

I'm not sure what the issue is yet, I checked usr/include/asm-generic/siginfo.h in our sysroot and it contains the SI_DETHREAD definition.

Jlalond · May 27, 2025

@petrhosek Hey Petr, can you provide more information? For Linux environments, SI_DETHREAD should be present. The commit for this signal specifically is 13 years old, @DavidSpickett do you have any insight as to why this is happening?
SI_DETHREAD
(Updated with an actually useful Linux line number)

I'm not sure what the issue is yet, I checked usr/include/asm-generic/siginfo.h in our sysroot and it contains the SI_DETHREAD definition.

Because the Linux CI is passing, are you opposed to merging the reapply? I'm not sure how I would help debug your builders failing to link it. We could also drop SI_DETHREAD for now and follow up in the future.

Reapply

labath · May 28, 2025

@petrhosek Hey Petr, can you provide more information? For Linux environments, SI_DETHREAD should be present. The commit for this signal specifically is 13 years old, @DavidSpickett do you have any insight as to why this is happening?
SI_DETHREAD
(Updated with an actually useful Linux line number)

I'm not sure what the issue is yet, I checked usr/include/asm-generic/siginfo.h in our sysroot and it contains the SI_DETHREAD definition.

This is a linux kernel header, and is not included when building regular applications. For me, the definition of SI_DETHREAD comes from /usr/include/bits/siginfo-consts.h (which comes from (g)libc). Maybe you don't have it if you have an old libc version.

I also checked the glibc version used internally at google (2.27, which is "only" seven years old :/), and it also does not have this symbol.

Because the Linux CI is passing, are you opposed to merging the reapply? I'm not sure how I would help debug your builders failing to link it. We could also drop SI_DETHREAD for now and follow up in the future.

It's true that these libraries are old, but it seems wrong to make this not build on (old) linuxes if the code actually builds on windows. We are actually providing the hardcoded values of these constants. The only reason we're referencing the os-defined values is so we can validate our values for them. There's already a precedent for handling unavailable constants, so you could just do the same with these.

(Although overall, I think it be better to move these checks to a test where the checks for individual constants could be guarded by #ifdef SI_CONSTANT)

Jlalond requested review from ashgti, labath, clayborg and jeffreytan81 May 15, 2025 22:04

Jlalond requested a review from JDevlieghere as a code owner May 15, 2025 22:04

llvmbot added the lldb label May 15, 2025

youngd007 reviewed May 15, 2025

View reviewed changes

Jlalond changed the title ~~[LLDB] Support all the Generic (Negative) SI Codes.~~ [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. May 15, 2025

Jlalond commented May 15, 2025

View reviewed changes

labath reviewed May 16, 2025

View reviewed changes

labath reviewed May 20, 2025

View reviewed changes

Jlalond added 11 commits May 22, 2025 14:11

Update ThreadElfCore

94d78d5

Add sender option to LinuxSignals.cpp

5e5869e

Add test for sender case

49cd55f

run GCF

01e0911

Reconfigure the parsing to get the bytes and convert to value object,…

958f1d5

… then parse that in thlinux signals

Refactor from testing, discovered that the compiler type generated si…

3e49ae9

…gnal differs from the linux definition

Run GCF

6b0c953

Set signo to 0 during initialization, fixes shell tests

6c7fe04

Fix signal being overwritten

a64901e

Add checks for all sp's in LinuxSignals.cpp

63d3008

Move everything to platform

503e58a

Jlalond force-pushed the siginfo_si_code_negative branch from b83eae4 to 503e58a Compare May 22, 2025 21:11

labath reviewed May 23, 2025

View reviewed changes

Fix coding standards in PlatformLinux, remove sinoinfo=0

a2abeb1

labath approved these changes May 27, 2025

View reviewed changes

Jlalond merged commit ff7bb17 into llvm:main May 27, 2025
10 checks passed

Jlalond mentioned this pull request May 27, 2025

[lldb] Add release note about ELF thread siginfo and negative SI Codes. #141631

Merged

Jlalond added a commit that referenced this pull request May 27, 2025

Revert "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (…

8da155e

…#140150)" This reverts commit ff7bb17.

Jlalond mentioned this pull request May 27, 2025

Revert "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." #141645

Merged

Jlalond added a commit that referenced this pull request May 27, 2025

Revert "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (

9d33b92

#141645) Reverts #140150 Broke the Darwin tests, but they pass on Linux. Reverting to make the build healthy while I investigate

		sifields.kill.pid = data.GetU32(&offset);
		sifields.kill.uid = data.GetU32(&offset);

Search code, repositories, users, issues, pull requests...

[LLDB][ELF Core] Support all the Generic (Negative) SI Codes. #140150

[LLDB][ELF Core] Support all the Generic (Negative) SI Codes. #140150

Uh oh!

Conversation

Jlalond commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

llvmbot commented May 15, 2025

Uh oh!

youngd007 May 15, 2025

Choose a reason for hiding this comment

Uh oh!

Jlalond May 15, 2025

Choose a reason for hiding this comment

Uh oh!

Jlalond May 15, 2025

Choose a reason for hiding this comment

Uh oh!

labath left a comment

Choose a reason for hiding this comment

Uh oh!

Jlalond commented May 16, 2025

Uh oh!

labath left a comment

Choose a reason for hiding this comment

Uh oh!

labath commented May 20, 2025

Uh oh!

Jlalond commented May 20, 2025

Uh oh!

labath commented May 20, 2025

Uh oh!

Jlalond commented May 22, 2025

Uh oh!

labath left a comment

Choose a reason for hiding this comment

Uh oh!

labath May 23, 2025

Choose a reason for hiding this comment

Uh oh!

Jlalond May 23, 2025

Choose a reason for hiding this comment

Uh oh!

labath May 23, 2025

Choose a reason for hiding this comment

Uh oh!

Jlalond commented May 23, 2025

Uh oh!

labath left a comment

Choose a reason for hiding this comment

Uh oh!

DavidSpickett commented May 27, 2025

Uh oh!

Jlalond commented May 27, 2025

Uh oh!

Uh oh!

felipepiovezan commented May 27, 2025

Uh oh!

Jlalond commented May 27, 2025

Uh oh!

JDevlieghere commented May 27, 2025

Uh oh!

Jlalond commented May 27, 2025

Uh oh!

petrhosek commented May 27, 2025

Uh oh!

Jlalond commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petrhosek commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jlalond commented May 27, 2025

Uh oh!

labath commented May 28, 2025

Uh oh!

Uh oh!

Jlalond commented May 15, 2025 •

edited

Loading

Jlalond commented May 27, 2025 •

edited

Loading

petrhosek commented May 27, 2025 •

edited

Loading