[NFC][Clang] Adopt simplified getTrailingObjects in ASTConcept
#139974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use non-templated form of `getTrailingObjects` when using a single trailing type in `TrailingObjects`.
|
@llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) ChangesUse non-templated form of Full diff: https://github.com/llvm/llvm-project/pull/139974.diff 2 Files Affected:
diff --git a/clang/include/clang/AST/ASTConcept.h b/clang/include/clang/AST/ASTConcept.h
index 078e1e848f393..c8f6330a73bb1 100644
--- a/clang/include/clang/AST/ASTConcept.h
+++ b/clang/include/clang/AST/ASTConcept.h
@@ -93,11 +93,11 @@ struct ASTConstraintSatisfaction final :
bool ContainsErrors : 1;
const UnsatisfiedConstraintRecord *begin() const {
- return getTrailingObjects<UnsatisfiedConstraintRecord>();
+ return getTrailingObjects();
}
const UnsatisfiedConstraintRecord *end() const {
- return getTrailingObjects<UnsatisfiedConstraintRecord>() + NumRecords;
+ return getTrailingObjects() + NumRecords;
}
ASTConstraintSatisfaction(const ASTContext &C,
diff --git a/clang/lib/AST/ASTConcept.cpp b/clang/lib/AST/ASTConcept.cpp
index f7ee0fb3ee92d..c9adccdbc77ef 100644
--- a/clang/lib/AST/ASTConcept.cpp
+++ b/clang/lib/AST/ASTConcept.cpp
@@ -40,9 +40,8 @@ ASTConstraintSatisfaction::ASTConstraintSatisfaction(
IsSatisfied{Satisfaction.IsSatisfied}, ContainsErrors{
Satisfaction.ContainsErrors} {
for (unsigned I = 0; I < NumRecords; ++I)
- CreateUnsatisfiedConstraintRecord(
- C, Satisfaction.Details[I],
- getTrailingObjects<UnsatisfiedConstraintRecord>() + I);
+ CreateUnsatisfiedConstraintRecord(C, Satisfaction.Details[I],
+ getTrailingObjects() + I);
}
ASTConstraintSatisfaction::ASTConstraintSatisfaction(
@@ -51,9 +50,8 @@ ASTConstraintSatisfaction::ASTConstraintSatisfaction(
IsSatisfied{Satisfaction.IsSatisfied},
ContainsErrors{Satisfaction.ContainsErrors} {
for (unsigned I = 0; I < NumRecords; ++I)
- CreateUnsatisfiedConstraintRecord(
- C, *(Satisfaction.begin() + I),
- getTrailingObjects<UnsatisfiedConstraintRecord>() + I);
+ CreateUnsatisfiedConstraintRecord(C, *(Satisfaction.begin() + I),
+ getTrailingObjects() + I);
}
ASTConstraintSatisfaction *
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use non-templated form of
getTrailingObjectswhen using a single trailing type inTrailingObjects.