Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Complete the Implementation of DAP modules explorer. #139934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2025
Merged

Complete the Implementation of DAP modules explorer. #139934

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7dbd5f7
[lldb][lldb-dap] clarify the todo.
da-viper May 14, 2025
3a5576d
[lldb][lldb-dap] show load address in hex for all dap-clients.
da-viper May 14, 2025
5adba9b
[lldb][lldb-dap] add review changes.
da-viper May 14, 2025
e155adb
[lldb][lldb-dap] do not show copy context in the command palette
da-viper May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[lldb][lldb-dap] add review changes.
  • Loading branch information
@da-viper
da-viper committed May 14, 2025
commit 5adba9bd7a078b28ac48a7c69633c7bdbbabe2e8
11 changes: 5 additions & 6 deletions 11 lldb/tools/lldb-dap/JSONUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,12 +416,11 @@ llvm::json::Value CreateModule(lldb::SBTarget &target, lldb::SBModule &module,
} else {
object.try_emplace("symbolStatus", "Symbols not found.");
}
std::string loaded_addr;
llvm::raw_string_ostream os_hex(loaded_addr);
os_hex << llvm::format_hex(
module.GetObjectFileHeaderAddress().GetLoadAddress(target),
sizeof(lldb::addr_t));
object.try_emplace("addressRange", loaded_addr);
std::string load_address =
llvm::formatv("{0:x}",
module.GetObjectFileHeaderAddress().GetLoadAddress(target))
.str();
object.try_emplace("addressRange", load_address);
std::string version_str;
uint32_t version_nums[3];
uint32_t num_versions =
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.