Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[lldb] Simplify a string comparison (NFC) #139932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kazutakahirata
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented May 14, 2025

@llvm/pr-subscribers-lldb

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/139932.diff

1 Files Affected:

  • (modified) lldb/source/Plugins/ExpressionParser/Clang/ASTStructExtractor.cpp (+1-2)
diff --git a/lldb/source/Plugins/ExpressionParser/Clang/ASTStructExtractor.cpp b/lldb/source/Plugins/ExpressionParser/Clang/ASTStructExtractor.cpp
index a2722db5d24a0..451cf40e2818d 100644
--- a/lldb/source/Plugins/ExpressionParser/Clang/ASTStructExtractor.cpp
+++ b/lldb/source/Plugins/ExpressionParser/Clang/ASTStructExtractor.cpp
@@ -123,8 +123,7 @@ void ASTStructExtractor::ExtractFromTopLevelDecl(Decl *D) {
   FunctionDecl *function_decl = dyn_cast<FunctionDecl>(D);
 
   if (m_ast_context && function_decl &&
-      !m_function.m_wrapper_function_name.compare(
-          function_decl->getNameAsString())) {
+      m_function.m_wrapper_function_name == function_decl->getNameAsString()) {
     ExtractFromFunctionDecl(function_decl);
   }
 }

@kazutakahirata kazutakahirata merged commit 539265b into llvm:main May 14, 2025
12 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_string_compare_lldb branch May 14, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.