Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[lldb] Use llvm::is_contained (NFC) #139758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kazutakahirata
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented May 13, 2025

@llvm/pr-subscribers-lldb

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/139758.diff

1 Files Affected:

  • (modified) lldb/tools/lldb-dap/DAP.cpp (+1-2)
diff --git a/lldb/tools/lldb-dap/DAP.cpp b/lldb/tools/lldb-dap/DAP.cpp
index 4feca1253be20..51f9da854f4b6 100644
--- a/lldb/tools/lldb-dap/DAP.cpp
+++ b/lldb/tools/lldb-dap/DAP.cpp
@@ -1194,8 +1194,7 @@ bool SendEventRequestHandler::DoExecute(lldb::SBDebugger debugger,
                                    "exited",     "initialize",   "loadedSource",
                                    "module",     "process",      "stopped",
                                    "terminated", "thread"};
-  if (std::find(internal_events.begin(), internal_events.end(), name) !=
-      std::end(internal_events)) {
+  if (llvm::is_contained(internal_events, name)) {
     std::string msg =
         llvm::formatv("Invalid use of lldb-dap send-event, event \"{0}\" "
                       "should be handled by lldb-dap internally.",

@kazutakahirata kazutakahirata merged commit 85bbf8c into llvm:main May 13, 2025
13 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_range_llvm_is_contained_lldb branch May 13, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.