Fix tests of lookup table generator #139463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the Python code formatter. |
6b842df to
744ba35
Compare
|
@llvm/pr-subscribers-clang Author: Robin Caloudis (robincaloudis) ChangesWhyIn https://github.com/llvm/llvm-project/pull/113612/files#diff-ada12e18f3e902b41b6989b46455c4e32656276e59907026e2464cf57d10d583, the parameter WhatFix the execution of tests by providing the missing argument. Full diff: https://github.com/llvm/llvm-project/pull/139463.diff 1 Files Affected:
diff --git a/clang/tools/include-mapping/test.py b/clang/tools/include-mapping/test.py
index eef328381f2bb..81803855dac8f 100755
--- a/clang/tools/include-mapping/test.py
+++ b/clang/tools/include-mapping/test.py
@@ -52,7 +52,7 @@ def testParseSymbolPage_SingleHeader(self):
</tr>
</tbody></table>
"""
- self.assertEqual(_ParseSymbolPage(html, "foo"), set(["<cmath>"]))
+ self.assertEqual(_ParseSymbolPage(html, "foo", "foo"), set(["<cmath>"]))
def testParseSymbolPage_MulHeaders(self):
# Defined in header <cstddef>
@@ -92,7 +92,9 @@ def testParseSymbolPage_MulHeaders(self):
</tr>
</tbody></table>
"""
- self.assertEqual(_ParseSymbolPage(html, "foo"), set(["<cstdio>", "<cstdlib>"]))
+ self.assertEqual(
+ _ParseSymbolPage(html, "foo", "foo"), set(["<cstdio>", "<cstdlib>"])
+ )
def testParseSymbolPage_MulHeadersInSameDiv(self):
# Multile <code> blocks in a Div.
@@ -118,7 +120,7 @@ def testParseSymbolPage_MulHeadersInSameDiv(self):
</tbody></table>
"""
self.assertEqual(
- _ParseSymbolPage(html, "foo"), set(["<algorithm>", "<utility>"])
+ _ParseSymbolPage(html, "foo", "foo"), set(["<algorithm>", "<utility>"])
)
def testParseSymbolPage_MulSymbolsInSameTd(self):
@@ -142,8 +144,10 @@ def testParseSymbolPage_MulSymbolsInSameTd(self):
</tr>
</tbody></table>
"""
- self.assertEqual(_ParseSymbolPage(html, "int8_t"), set(["<cstdint>"]))
- self.assertEqual(_ParseSymbolPage(html, "int16_t"), set(["<cstdint>"]))
+ self.assertEqual(_ParseSymbolPage(html, "int8_t", "int8_t"), set(["<cstdint>"]))
+ self.assertEqual(
+ _ParseSymbolPage(html, "int16_t", "int16_t"), set(["<cstdint>"])
+ )
if __name__ == "__main__":
|
|
@owenca and @mydeveloperday, do you mind to take a look when you find some time? Thanks in advance. |
kadircet
approved these changes
May 27, 2025
|
@kadircet, can you merge this PR? I lack write access. Thank you. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/11940 Here is the relevant piece of the build log for the reference |
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
## Why In https://github.com/llvm/llvm-project/pull/113612/files#diff-ada12e18f3e902b41b6989b46455c4e32656276e59907026e2464cf57d10d583, the parameter `qual_name` was introduced. However, the tests have not been adopted accordingly and hence cannot be executed. ## What Fix the execution of tests by providing the missing argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In https://github.com/llvm/llvm-project/pull/113612/files#diff-ada12e18f3e902b41b6989b46455c4e32656276e59907026e2464cf57d10d583, the parameter
qual_namewas introduced. However, the tests have not been adopted accordingly and hence cannot be executed.What
Fix the execution of tests by providing the missing argument.