Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[CoroEarly] Hide promise alloca for later passes #139243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 16, 2025
Merged

[CoroEarly] Hide promise alloca for later passes #139243

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fa9149a
[Coro] Hide promise alloca for later passes
NewSigma May 9, 2025
2908155
Reformat
NewSigma May 12, 2025
28596aa
Handle cases that coro.promise may be inlined
NewSigma May 12, 2025
e1008df
Handle cases coro handle may be passed to another coroutine
NewSigma May 12, 2025
cb7bb71
Only emit coro.promise if CoroBegin is nonnull
NewSigma May 13, 2025
dc0bd0a
Make use of uniqueness of coro.promise
NewSigma May 13, 2025
4249143
Format code
NewSigma May 13, 2025
b7c158e
Refactor and add comment
NewSigma May 14, 2025
8476d7e
Add NoDuplicate to coro.promise
NewSigma May 15, 2025
71d0e86
Remove unnecessary code
NewSigma May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reformat
  • Loading branch information
@NewSigma
NewSigma committed May 12, 2025
commit 2908155efeaa065c9c8f90e355ad4820195a7cc3
6 changes: 2 additions & 4 deletions 6 llvm/lib/Transforms/Coroutines/CoroEarly.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#include "llvm/Transforms/Coroutines/CoroEarly.h"
#include "CoroInternal.h"
#include "llvm/IR/DIBuilder.h"
#include "llvm/IR/Dominators.h"
#include "llvm/IR/Function.h"
#include "llvm/IR/IRBuilder.h"
#include "llvm/IR/InstIterator.h"
Expand Down Expand Up @@ -264,9 +263,8 @@ void Lowerer::lowerEarlyIntrinsics(Function &F) {
auto *Alignment = Builder.getInt32(PA->getAlign().value());
auto *FromPromise = Builder.getInt1(false);
SmallVector<Value *, 3> Arg{CoroBegin, Alignment, FromPromise};
auto *PI =
Builder.CreateIntrinsic(Builder.getPtrTy(), Intrinsic::coro_promise,
Arg, {}, "promise.addr");
auto *PI = Builder.CreateIntrinsic(
Builder.getPtrTy(), Intrinsic::coro_promise, Arg, {}, "promise.addr");
PA->replaceUsesWithIf(PI, [CoroId](Use &U) {
bool IsBitcast = U == U.getUser()->stripPointerCasts();
bool IsCoroId = U.getUser() == CoroId;
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.