Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[mlir][AMDGPU] Add missing dependency #137107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025

Conversation

Muzammiluddin-Syed-ECE
Copy link
Contributor

Add missing deps after 905f1d8

Signed-off-by: Muzammiluddin Syed <muzasyed@amd.com>
@llvmbot
Copy link
Member

llvmbot commented Apr 24, 2025

@llvm/pr-subscribers-mlir-gpu

@llvm/pr-subscribers-mlir

Author: Muzammil (Muzammiluddin-Syed-ECE)

Changes

Add missing deps after 905f1d8


Full diff: https://github.com/llvm/llvm-project/pull/137107.diff

1 Files Affected:

  • (modified) mlir/lib/Dialect/GPU/CMakeLists.txt (+1)
diff --git a/mlir/lib/Dialect/GPU/CMakeLists.txt b/mlir/lib/Dialect/GPU/CMakeLists.txt
index 013311ec027da..1074760aa959e 100644
--- a/mlir/lib/Dialect/GPU/CMakeLists.txt
+++ b/mlir/lib/Dialect/GPU/CMakeLists.txt
@@ -53,6 +53,7 @@ add_mlir_dialect_library(MLIRGPUTransforms
 
   LINK_LIBS PUBLIC
   MLIRAffineUtils
+  MLIRAMDGPUDialect
   MLIRArithDialect
   MLIRAsyncDialect
   MLIRBufferizationDialect

Signed-off-by: Muzammiluddin Syed <muzasyed@amd.com>
@Muzammiluddin-Syed-ECE
Copy link
Contributor Author

Successfully fixes the build issues caused by 905f1d8

Integration Test Results:

Running the MLIR regression tests

Testing Time: 67.74s

Total Discovered Tests: 3219
  Skipped          :    1 (0.03%)
  Unsupported      :  223 (6.93%)
  Passed           : 2994 (93.01%)
  Expectedly Failed:    1 (0.03%)

@krzysz00 krzysz00 merged commit 30fec12 into llvm:main Apr 24, 2025
9 of 10 checks passed
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Add missing deps after
llvm@905f1d8

---------

Signed-off-by: Muzammiluddin Syed <muzasyed@amd.com>
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Add missing deps after
llvm@905f1d8

---------

Signed-off-by: Muzammiluddin Syed <muzasyed@amd.com>
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Add missing deps after
llvm@905f1d8

---------

Signed-off-by: Muzammiluddin Syed <muzasyed@amd.com>
Ankur-0429 pushed a commit to Ankur-0429/llvm-project that referenced this pull request May 9, 2025
Add missing deps after
llvm@905f1d8

---------

Signed-off-by: Muzammiluddin Syed <muzasyed@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.