Open
Description
This issue handles the additional semantic analysis of the parsed HLSLRootSignature
attribute. This includes generating applicable diagnostics.
The relevant validations that this issue must implement are:
- Ensure valid values of
DESCRIPTOR_RANGE_FLAGS
for theSampler
descriptor table clause - Ensure that listed parameters of
StaticSampler
are bounded correctly - Validate that the
space
parameter is not in the invalid range of0xFFFFFFF0
to0xFFFFFFFF
- Validate that the
numDescriptors
parameter is not 0. - Ensure that the correct register type matches the desriptor range type
AC:
- Update
ParseHLSLRootSignature
defined in [HLSL] Generate AST for Root Signatures #119011 to implement semantic validation ofHLSLRootSignature
- Update
handleHLSLRootSignature
to implement semantic validation ofHLSLRootSignature
inSemaHLSL.cpp
- Add thorough testing of correct diagnostics into
clang/unittests/Sema/ParseHLSLRootSignatureTest.cpp
- Add tests for some samples to ensure diagnostics are displayed correctly from HLSL input in
AST/HLSL/RootSignatures-AST.hlsl
Metadata
Metadata
Assignees
Labels
HLSL Language SupportHLSL Language Support
Type
Projects
Status
Active