llvm
diff --git a/‎mlir/include/mlir/Dialect/MLProgram/IR/MLProgramAttributes.td
Copy file name to clipboardExpand all lines: mlir/include/mlir/Dialect/MLProgram/IR/MLProgramAttributes.td
+13-1Lines changed: 13 additions & 1 deletion b/‎mlir/include/mlir/Dialect/MLProgram/IR/MLProgramAttributes.td
Copy file name to clipboardExpand all lines: mlir/include/mlir/Dialect/MLProgram/IR/MLProgramAttributes.td
+13-1Lines changed: 13 additions & 1 deletion
diff --git a/‎mlir/lib/Dialect/MLProgram/IR/MLProgramDialect.cpp
Copy file name to clipboardExpand all lines: mlir/lib/Dialect/MLProgram/IR/MLProgramDialect.cpp
-8Lines changed: 0 additions & 8 deletions b/‎mlir/lib/Dialect/MLProgram/IR/MLProgramDialect.cpp
Copy file name to clipboardExpand all lines: mlir/lib/Dialect/MLProgram/IR/MLProgramDialect.cpp
-8Lines changed: 0 additions & 8 deletions
@@ -11,6 +11,7 @@
 
 include "mlir/IR/AttrTypeBase.td"
 include "mlir/IR/BuiltinAttributeInterfaces.td"
+include "mlir/IR/OpAsmInterface.td"
 include "mlir/Dialect/MLProgram/IR/MLProgramBase.td"
 
 // Base class for MLProgram dialect attributes.
@@ -23,7 +24,7 @@ class MLProgram_Attr<string name, list<Trait> traits = []>
 // ExternAttr
 //===----------------------------------------------------------------------===//
 
-def MLProgram_ExternAttr : MLProgram_Attr<"Extern", [TypedAttrInterface]> {
+def MLProgram_ExternAttr : MLProgram_Attr<"Extern", [TypedAttrInterface, OpAsmAttrInterface]> {
   let summary = "Value used for a global signalling external resolution";
   let description = [{
   When used as the value for a GlobalOp, this indicates that the actual
@@ -40,6 +41,17 @@ def MLProgram_ExternAttr : MLProgram_Attr<"Extern", [TypedAttrInterface]> {
   let parameters = (ins AttributeSelfTypeParameter<"">:$type);
   let mnemonic = "extern";
   let assemblyFormat = "";
+
+  let extraClassDeclaration = [{
+    //===------------------------------------------------------------------===//
+    // OpAsmAttrInterface Methods
+    //===------------------------------------------------------------------===//
+
+    ::mlir::OpAsmAliasResult getAlias(::llvm::raw_ostream &os) const {
+      os << "}] # mnemonic # [{";
+      return ::mlir::OpAsmAliasResult::OverridableAlias;
+    }
+  }];
 }
 
 #endif // MLPROGRAM_ATTRIBUTES
@@ -39,14 +39,6 @@ struct MLProgramInlinerInterface : public DialectInlinerInterface {
 
 struct MLProgramOpAsmDialectInterface : public OpAsmDialectInterface {
   using OpAsmDialectInterface::OpAsmDialectInterface;
-
-  AliasResult getAlias(Attribute attr, raw_ostream &os) const override {
-    if (llvm::isa<ExternAttr>(attr)) {
-      os << "extern";
-      return AliasResult::OverridableAlias;
-    }
-    return AliasResult::NoAlias;
-  }
 };
 } // namespace