Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2d92dc3

Browse filesBrowse files
committed
Delete FIXME according to review.
1 parent a2768a5 commit 2d92dc3
Copy full SHA for 2d92dc3

File tree

1 file changed

+3
-3
lines changed
Filter options

1 file changed

+3
-3
lines changed

‎lld/ELF/Arch/LoongArch.cpp

Copy file name to clipboardExpand all lines: lld/ELF/Arch/LoongArch.cpp
+3-3
Original file line numberDiff line numberDiff line change
@@ -1161,9 +1161,9 @@ void LoongArch::tlsdescToLe(uint8_t *loc, const Relocation &rel,
11611161
// * pcalau12i $a0, %pc_hi20(sym)
11621162
// * addi.w/d $a0, $a0, %pc_lo12(sym)
11631163
//
1164-
// FIXME: Althouth the optimization has been performed, the GOT entries still
1165-
// exists, similarly to AArch64. Eliminating the entries may be require
1166-
// additional marking in the common code.
1164+
// Note: Althouth the optimization has been performed, the GOT entries still
1165+
// exists, similarly to AArch64. Eliminating the entries will increase code
1166+
// complexity.
11671167
bool LoongArch::tryGotToPCRel(uint8_t *loc, const Relocation &rHi20,
11681168
const Relocation &rLo12, uint64_t secAddr) const {
11691169
if (!rHi20.sym->isDefined() || rHi20.sym->isPreemptible ||

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.