llvm
diff --git a/‎llvm/lib/Transforms/IPO/LowerTypeTests.cpp
Copy file name to clipboardExpand all lines: llvm/lib/Transforms/IPO/LowerTypeTests.cpp
+15-1Lines changed: 15 additions & 1 deletion b/‎llvm/lib/Transforms/IPO/LowerTypeTests.cpp
Copy file name to clipboardExpand all lines: llvm/lib/Transforms/IPO/LowerTypeTests.cpp
+15-1Lines changed: 15 additions & 1 deletion
diff --git a/‎llvm/test/Transforms/LowerTypeTests/cfi-coff-comdat-rename.ll
Copy file name to clipboard
+36Lines changed: 36 additions & 0 deletions b/‎llvm/test/Transforms/LowerTypeTests/cfi-coff-comdat-rename.ll
Copy file name to clipboard
+36Lines changed: 36 additions & 0 deletions
@@ -1711,8 +1711,22 @@ void LowerTypeTestsModule::buildBitSetsFromFunctionsNative(
           F->getValueType(), 0, F->getLinkage(), "", CombinedGlobalElemPtr, &M);
       FAlias->setVisibility(F->getVisibility());
       FAlias->takeName(F);
-      if (FAlias->hasName())
+      if (FAlias->hasName()) {
         F->setName(FAlias->getName() + ".cfi");
+        // For COFF we should also rename the comdat if this function also
+        // happens to be the key function. Even if the comdat name changes, this
+        // should still be fine since comdat and symbol resolution happens
+        // before LTO, so all symbols which would prevail have been selected.
+        if (F->hasComdat() && ObjectFormat == Triple::COFF &&
+            F->getComdat()->getName() == FAlias->getName()) {
+          Comdat *OldComdat = F->getComdat();
+          Comdat *NewComdat = M.getOrInsertComdat(F->getName());
+          for (GlobalObject &GO : M.global_objects()) {
+            if (GO.getComdat() == OldComdat)
+              GO.setComdat(NewComdat);
+          }
+        }
+      }
       replaceCfiUses(F, FAlias, IsJumpTableCanonical);
       if (!F->hasLocalLinkage())
         F->setVisibility(GlobalVariable::HiddenVisibility);
 
@@ -0,0 +1,36 @@
+; REQUIRES: x86-registered-target
+; RUN: opt -S -passes=lowertypetests %s | FileCheck %s
+
+;; This is a check to assert we don't crash with:
+;;
+;;   LLVM ERROR: Associative COMDAT symbol '...' does not exist.
+;;
+;; So this just needs to exit normally.
+; RUN: opt -S -passes=lowertypetests %s | llc -asm-verbose=false
+
+target datalayout = "e-p:64:64"
+target triple = "x86_64-pc-windows-msvc"
+
+@a = global [2 x ptr] [ptr @f1, ptr @f2]
+
+; CHECK: $f1.cfi = comdat any
+$f1 = comdat any
+
+; CHECK: @f1.cfi() comdat !type !0
+define void @f1() comdat !type !0 {
+  ret void
+}
+
+; CHECK: @f2.cfi() comdat($f1.cfi) !type !0
+define void @f2() comdat($f1) !type !0 {
+  ret void
+}
+
+declare i1 @llvm.type.test(ptr %ptr, metadata %bitset) nounwind readnone
+
+define i1 @foo(ptr %p) {
+  %x = call i1 @llvm.type.test(ptr %p, metadata !"typeid1")
+  ret i1 %x
+}
+
+!0 = !{i32 0, !"typeid1"}