Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 1782831

Browse filesBrowse files
committed
[lldb][lldb-dap] review changes
1 parent 98659ed commit 1782831
Copy full SHA for 1782831

File tree

2 files changed

+5
-3
lines changed
Filter options

2 files changed

+5
-3
lines changed

‎lldb/tools/lldb-dap/Protocol/ProtocolRequests.h

Copy file name to clipboardExpand all lines: lldb/tools/lldb-dap/Protocol/ProtocolRequests.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ struct ScopesArguments {
443443
/// Retrieve the scopes for the stack frame identified by `frameId`. The
444444
/// `frameId` must have been obtained in the current suspended state. See
445445
/// 'Lifetime of Object References' in the Overview section for details.
446-
uint64_t frameId;
446+
uint64_t frameId = LLDB_INVALID_FRAME_ID;
447447
};
448448
bool fromJSON(const llvm::json::Value &, ScopesArguments &, llvm::json::Path);
449449

‎lldb/tools/lldb-dap/Protocol/ProtocolTypes.h

Copy file name to clipboardExpand all lines: lldb/tools/lldb-dap/Protocol/ProtocolTypes.h
+4-2Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@
2727
#include <optional>
2828
#include <string>
2929

30+
#define LLDB_DAP_INVALID_VARRERF UINT64_MAX
31+
3032
namespace lldb_dap::protocol {
3133

3234
/// An `ExceptionBreakpointsFilter` is shown in the UI as an filter option for
@@ -336,7 +338,7 @@ struct Scope {
336338
/// remains suspended. See 'Lifetime of Object References' in the Overview
337339
/// section for details.
338340
////
339-
uint64_t variablesReference;
341+
uint64_t variablesReference = LLDB_DAP_INVALID_VARRERF;
340342

341343
/// The number of named variables in this scope.
342344
/// The client can use this information to present the variables in a paged UI
@@ -353,7 +355,7 @@ struct Scope {
353355

354356
/// If true, the number of variables in this scope is large or expensive to
355357
/// retrieve.
356-
bool expensive;
358+
bool expensive = false;
357359

358360
/// The start line of the range covered by this scope.
359361
std::optional<uint64_t> line;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.