Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 147c623

Browse filesBrowse files
dyungdyung
authored
Change check for embedded llvm version number to a regex to make test more flexible. (#79528) (#79642)
This test started to fail when LLVM created the release/18.x branch and the main branch subsequently had the version number increased from 18 to 19. I investigated this failure (it was blocking our internal automation) and discovered that the CHECK statement on line 27 seemed to have the compiler version number (1800) encoded in octal that it was checking for. I don't know if this is something that explicitly needs to be checked, so I am leaving it in, but it should be more flexible so the test doesn't fail anytime the version number is changed. To accomplish that, I changed the check for the 4-digit version number to be a regex. I originally updated this test for the 18->19 transition in a01195f. This change makes the CHECK line more flexible so it doesn't need to be continually updated. (cherry picked from commit 45f883e)
1 parent 0991d3c commit 147c623
Copy full SHA for 147c623

File tree

1 file changed

+1
-1
lines changed
Filter options

1 file changed

+1
-1
lines changed

‎llvm/test/CodeGen/SystemZ/zos-ppa2.ll

Copy file name to clipboardExpand all lines: llvm/test/CodeGen/SystemZ/zos-ppa2.ll
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
; CHECK: .byte 0
2525
; CHECK: .byte 3
2626
; CHECK: .short 30
27-
; CHECK: .ascii "\323\323\345\324@@@@@@\361\370\360\360\361\371\367\360\360\361\360\361\360\360\360\360\360\360\360\360"
27+
; CHECK: .ascii "\323\323\345\324@@@@@@{{((\\3[0-7]{2}){4})}}\361\371\367\360\360\361\360\361\360\360\360\360\360\360\360\360"
2828
define void @void_test() {
2929
entry:
3030
ret void

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.