Add support for datachannel encryption#512
Merged
Add support for datachannel encryption#512
Conversation
xianshijing-lk
approved these changes
Oct 10, 2025
Contributor
xianshijing-lk
left a comment
There was a problem hiding this comment.
please address the comment, if that code is needed, put in a comment to explain.
lgtm in general
Contributor
Author
|
will merge this after #516 has been merged |
Member
Contributor
Author
|
Would have to take a closer look whether we can safely remove it, but I think this can be done as a follow up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also exposes participantEncryptionChanged event and updates rust sdks (currently not to a new FFI build, which needs to get fixed)