fix: update protos and allow ListUpdate.{add,remove} in SIP cmds#496
Merged
rektdeckard merged 4 commits intomainlivekit/python-sdks:mainfrom Oct 1, 2025
Merged
fix: update protos and allow ListUpdate.{add,remove} in SIP cmds#496rektdeckard merged 4 commits intomainlivekit/python-sdks:mainfrom
rektdeckard merged 4 commits intomainlivekit/python-sdks:mainfrom
Conversation
|
Do we also need to update line 610 for the trunk_ids when updating SIPDispatchRules ? The proto shows usage of a ListUpdate here |
nishadmusthafa
approved these changes
Sep 13, 2025
c850a5a to
f54f5d6
Compare
Member
Author
|
@theomonnom tests seem to have trouble downloading |
f54f5d6 to
d28bc17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerate proto bindings and update SIP APIs to fully support
ListUpdatetype actions. In the previous PR, we lacked support for thedeloperation, since it is a reserved Python keyword and was not being generated in the Python protobuf bindings.