Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

Implement task_done calls after queue.wait_for#455

Open
thinhdanggroup wants to merge 1 commit intolivekit:mainlivekit/python-sdks:mainfrom
thinhdanggroup:fix-clean-up-resourcesthinhdanggroup/python-sdks:fix-clean-up-resourcesCopy head branch name to clipboard
Open

Implement task_done calls after queue.wait_for#455
thinhdanggroup wants to merge 1 commit intolivekit:mainlivekit/python-sdks:mainfrom
thinhdanggroup:fix-clean-up-resourcesthinhdanggroup/python-sdks:fix-clean-up-resourcesCopy head branch name to clipboard

Conversation

@thinhdanggroup
Copy link

@thinhdanggroup thinhdanggroup commented Jun 15, 2025 •
edited
Loading

  • I added task done after queue.wait_for finish to ensure proper task management and resource cleanup. I face the issue with memory leak for my service, this is first point I see that current library missing to mark event done.
  • I re-arrange order operations in AudioStream init method because of potential of missing FfiHandle before run loop started

@thinhdanggroup
Implement task_done calls for FFI queue in various RTC components to …
38adb3d 
…ensure proper task management and resource cleanup.
@CLAassistant
Copy link

CLAassistant commented Jun 15, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinh-dang-ts thinh-dang-ts mentioned this pull request Jun 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thinhdanggroup @CLAassistant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.