Move RPC handlers to room#395
Open
Move RPC handlers to room#395
Conversation
typester
commented
Mar 13, 2025
typester
commented
Mar 13, 2025
| @@ -483,7 +564,7 @@ def _on_rpc_method_invocation(self, rpc_invocation: RpcMethodInvocationEvent): | ||
|
|
||
| if rpc_invocation.local_participant_handle == self._local_participant._ffi_handle.handle: |
Contributor
Author
There was a problem hiding this comment.
Is this local_participant check still needed?
Contributor
There was a problem hiding this comment.
i think this is here in the case that you connect to multiple rooms simultaneously?
bcherry
approved these changes
Mar 14, 2025
theomonnom
reviewed
Mar 14, 2025
| "protobuf>=4.25.0", | ||
| "types-protobuf>=3", | ||
| "aiofiles>=24", | ||
| "deprecated>=1.2.18", |
Member
There was a problem hiding this comment.
nit: do we want to add a new package just for deprecation?
let's just log a warning no?
Member
There was a problem hiding this comment.
just saw this comment, either way #395 (comment) ...
Member
There was a problem hiding this comment.
we can log a warning too! I don't have a preference.. the only preference is making sure users know they are using a deprecated function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust-side: livekit/rust-sdks#599