This repository was archived by the owner on Aug 31, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 71
[Bug 4084] Multiline comments #1373
Open
montegoulding
wants to merge
2
commits into
livecode:develop
Choose a base branch
from
montegoulding:multilinecomments
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42e341e
to
9a567ca
Compare
Is this also related to bug 4084? |
Yes to fix 4084 we need to detect if a line is a multi-line comment or not and we need the same for colorization I've just added an _internal command to get the comment nesting for the line but the colorization still isn't quite right |
Okay thanks. It would be great to get this fixed. |
it actually has the release note already |
@montegoulding Yes but I wanted to put it in the title so I can more easily see what I need to poke in BZ when it gets merged. ;-) |
yes sorry I started working on it then I searched BZ after to try and find related reports |
cleared the milestone because multiline comments detection needs more work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on livecode/livecode#4425
It provides support for leading whitespace within multiline comment blocks and some basic editing
features (shift left | right, reindent) for when autoformat is disabled or within a multiline comment where it shouldn't apply.