Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

[Bug 4084] Multiline comments #1373

Open
wants to merge 2 commits into
base: develop
Choose a base branch
Loading
from

Conversation

montegoulding
Copy link
Member

This PR depends on livecode/livecode#4425

It provides support for leading whitespace within multiline comment blocks and some basic editing
features (shift left | right, reindent) for when autoformat is disabled or within a multiline comment where it shouldn't apply.

@peter-b peter-b added this to the 8.2.0-dp-1 milestone Aug 30, 2016
@peter-b
Copy link
Contributor

peter-b commented Aug 31, 2016

Is this also related to bug 4084?

@montegoulding
Copy link
Member Author

Yes to fix 4084 we need to detect if a line is a multi-line comment or not and we need the same for colorization I've just added an _internal command to get the comment nesting for the line but the colorization still isn't quite right

@peter-b
Copy link
Contributor

peter-b commented Aug 31, 2016

Okay thanks. It would be great to get this fixed.

@peter-b peter-b changed the title Multiline comments [Bug 4084] Multiline comments Aug 31, 2016
@montegoulding
Copy link
Member Author

it actually has the release note already

@peter-b
Copy link
Contributor

peter-b commented Aug 31, 2016

@montegoulding Yes but I wanted to put it in the title so I can more easily see what I need to poke in BZ when it gets merged. ;-)

@montegoulding
Copy link
Member Author

yes sorry I started working on it then I searched BZ after to try and find related reports

@peter-b peter-b modified the milestones: 9.0.0-dp-1, 9.0.0-dp-2 Sep 30, 2016
@peter-b peter-b modified the milestones: 9.0.0-dp-2, 9.0.0-dp-3, 9.0.0-dp-4 Nov 24, 2016
@livecodepanos livecodepanos added this to the 9.0.0-dp-5 milestone Dec 20, 2016
@livecodepanos livecodepanos removed this from the 9.0.0-dp-4 milestone Dec 20, 2016
@montegoulding montegoulding removed this from the 9.0.0-dp-5 milestone Feb 16, 2017
@montegoulding
Copy link
Member Author

cleared the milestone because multiline comments detection needs more work

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.