This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 23237 ]] Ensure Android EGL configuration supports GLES 3.x #7585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the android OpenGLView class to request an EGL configuration that supports GLES 3.x. This prevents a crash in the Android x86 emulator when attempting to use gl functions that are not supported by the default configuration.
This patch adds a release note for bug 23237, where using acceleratedRendering on an Android x86 emulator could lead to a crash
runrevmark
approved these changes
Jun 30, 2021
|
@livecode-vulcan review ok e7c088c |
|
💙 review by @runrevmark ok e7c088c |
livecode-vulcan
added a commit
that referenced
this pull request
Jun 30, 2021
[[ Bug 23237 ]] Ensure Android EGL configuration supports GLES 3.x This patch updates the android OpenGLView class to request an EGL configuration that supports GLES 3.x. This prevents a crash in the Android x86 emulator when attempting to use gl functions that are not supported by the default configuration. Fixes https://quality.livecode.com/show_bug.cgi?id=23237
|
😎 test success e7c088c
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the android OpenGLView class to request an EGL
configuration that supports GLES 3.x. This prevents a crash in the
Android x86 emulator when attempting to use gl functions that are not
supported by the default configuration.
Fixes https://quality.livecode.com/show_bug.cgi?id=23237