Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

[[ Bug 22802 ]] Fix crash in HTML5 standalones when fetching the system date or system time #7389

Merged
merged 2 commits into from
Jul 3, 2020

Conversation

livecodeian
Copy link
Contributor

This patch fixes a crash fetching system date & time values by using the posix implementation of MCS_getdatetimelocale, which was previously missing from the emscripten engine.

Closes https://quality.livecode.com/show_bug.cgi?id=22802

@livecodeian livecodeian added this to the 9.7.0-dp-1 milestone Jun 25, 2020
@livecodeian livecodeian requested a review from runrevmark June 25, 2020 16:42
@livecodeian livecodeian changed the base branch from develop to develop-9.6 July 2, 2020 10:15
This patch fixes a crash fetching system date & time values by using the
posix implementation of MCS_getdatetimelocale, which was previously
missing from the emscripten engine.
Copy link
Contributor

@runrevmark runrevmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with previous emscripten fixes (which have been split into fix + release note commits) - it should be [[ Emscripten ]] as the prefix in the main commit. (i.e. titlecase).

Copy link
Contributor

@runrevmark runrevmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main commit title prefix should be titlecase [[ Emscripten ]].

This patch adds a release note for bug 22802, where fetching the system
date could trigger a crash in the HTML5 engine
@runrevmark
Copy link
Contributor

@livecode-vulcan review ok f610335

@livecode-vulcan
Copy link
Contributor

💙 review by @runrevmark ok f610335

livecode-vulcan added a commit that referenced this pull request Jul 3, 2020
[[ Bug 22802 ]] Fix crash in HTML5 standalones when fetching the system date or system time

This patch fixes a crash fetching system date & time values by using the posix implementation of MCS_getdatetimelocale, which was previously missing from the emscripten engine.

Closes https://quality.livecode.com/show_bug.cgi?id=22802
@livecode-vulcan
Copy link
Contributor

😎 test success f610335

  • try-community-armv6-android-sdk26_ndk16r15: success
  • try-community-armv7-android-ndk16r15: success
  • try-community-arm64-android-ndk16r15: success
  • try-community-x86-android-ndk16r15: success
  • try-community-x86_64-android-ndk16r15: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos13.5: success
  • try-community-universal-ios-iphonesimulator13.5: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodepanos livecodepanos merged commit e777cb8 into livecode:develop-9.6 Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.