This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 22802 ]] Fix crash in HTML5 standalones when fetching the system date or system time #7389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a crash fetching system date & time values by using the posix implementation of MCS_getdatetimelocale, which was previously missing from the emscripten engine.
runrevmark
suggested changes
Jul 2, 2020
runrevmark
suggested changes
Jul 2, 2020
This patch adds a release note for bug 22802, where fetching the system date could trigger a crash in the HTML5 engine
|
@livecode-vulcan review ok f610335 |
|
💙 review by @runrevmark ok f610335 |
livecode-vulcan
added a commit
that referenced
this pull request
Jul 3, 2020
[[ Bug 22802 ]] Fix crash in HTML5 standalones when fetching the system date or system time This patch fixes a crash fetching system date & time values by using the posix implementation of MCS_getdatetimelocale, which was previously missing from the emscripten engine. Closes https://quality.livecode.com/show_bug.cgi?id=22802
|
😎 test success f610335
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a crash fetching system date & time values by using the posix implementation of MCS_getdatetimelocale, which was previously missing from the emscripten engine.
Closes https://quality.livecode.com/show_bug.cgi?id=22802