livecode · livecodepanos · Jul 2, 2020 · Jun 11, 2020 · livecodepanos · Jul 7, 2020
diff --git a/docs/notes/bugfix-22763.md b/docs/notes/bugfix-22763.md
@@ -0,0 +1 @@
+# Ensure mobilePickPhoto with width and height params works on older Android versions
diff --git a/engine/src/java/com/runrev/android/Engine.java b/engine/src/java/com/runrev/android/Engine.java
@@ -2232,9 +2232,18 @@ else if (resultCode == Activity.RESULT_OK)
 					float t_width = t_bitmap.getWidth();
 					float t_height = t_bitmap.getHeight();

-					InputStream t_exif_in = ((LiveCodeActivity)getContext()).getContentResolver().openInputStream(t_photo_uri);
-
-					ExifInterface t_exif = new ExifInterface(t_exif_in);
+					/* In API Level >= 24, you have to use an input stream to make sure that access
+					 * to a photo in the library is granted. Before that you can just open the photo's
+					 * file direct. */
+					ExifInterface t_exif;
+					if (Build.VERSION.SDK_INT >= 24)
+					{
+						t_exif = new ExifInterface(t_in);
+					}
+					else
+					{
+						t_exif = new ExifInterface(t_photo_uri.getPath());
+					}

 					int t_orientation = t_exif.getAttributeInt(ExifInterface.TAG_ORIENTATION,
 															   ExifInterface.ORIENTATION_NORMAL);
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		# Ensure mobilePickPhoto with width and height params works on older Android versions
-Original file line number
+Diff line change
@@ -2232,9 +2232,18 @@ else if (resultCode == Activity.RESULT_OK)
     					float t_width = t_bitmap.getWidth();
     					float t_height = t_bitmap.getHeight();
-    					InputStream t_exif_in = ((LiveCodeActivity)getContext()).getContentResolver().openInputStream(t_photo_uri);
-    					ExifInterface t_exif = new ExifInterface(t_exif_in);
+    					/* In API Level >= 24, you have to use an input stream to make sure that access
             Copy link

  
      
    
  

  
      

  
    Contributor


      

  Author


  

  
    
      

      
            livecodepanos
  

      

      

      


        Jul 7, 2020


      
  •

  
    
      
        
          edited
          
        
        
      
    
    
      
  
        
      Loading


  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  
    
  


    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Hmm, using the existing InputStream t_in causes the captured pic to be rotated 90 degrees. I am wondering if this was the reason @montegoulding used a new one (i.e. the t_exif_in one) in the first place.
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    

    



    
        
  
    
        
    
  


      
          
  
      
            Copy link

  
      
    
  

  
      

  
    Contributor


      

  

  
    
      

      
            runrevmark
  

      

      

      


        Jul 7, 2020


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Oh! Yes - the reason is that we've used the t_in stream above! Oops!
So below we should do:
if (Build.VERSION....)
{
    t_in.close();
    t_in = ((LiveCodeActivity)getContext()).getContentResolver().openInputStream(t_photo_uri);
}

This will close the (now finished) original stream, and then create a new one.
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
+    					 * to a photo in the library is granted. Before that you can just open the photo's
+    					 * file direct. */
+    					ExifInterface t_exif;
+    					if (Build.VERSION.SDK_INT >= 24)
+    					{
+    						t_exif = new ExifInterface(t_in);
+    					}
+    					else
+    					{
+    						t_exif = new ExifInterface(t_photo_uri.getPath());
+    					}
     					int t_orientation = t_exif.getAttributeInt(ExifInterface.TAG_ORIENTATION,
     															   ExifInterface.ORIENTATION_NORMAL);
-          Expand Down