This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[11170] Turn off auto-suggestion in Android native password fields #7359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livecodeian
reviewed
May 29, 2020
| @@ -247,7 +247,7 @@ public void setIsPassword(boolean p_password) | ||
| { | ||
| m_transformation_method = m_text_view.getTransformationMethod(); | ||
| m_text_view.setTransformationMethod(PasswordTransformationMethod.getInstance()); | ||
| m_text_view.setInputType(InputType.TYPE_TEXT_FLAG_NO_SUGGESTIONS); | ||
| m_text_view.setInputType(InputType.TYPE_TEXT_FLAG_NO_SUGGESTIONS | InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD); |
There was a problem hiding this comment.
Why use TYPE_TEXT_VARIATION_VISIBLE_PASSWORD instead of TYPE_TEXT_VARIATION_PASSWORD here?
Don't we want the contents to be hidden from the user?
There was a problem hiding this comment.
@livecodeian PR Updated :)
2a79ca3 to
7f4b9f4
Compare
|
@livecode-vulcan review ok 7f4b9f4 |
|
💙 review by @livecodeian ok 7f4b9f4 |
livecode-vulcan
added a commit
that referenced
this pull request
Jun 2, 2020
[11170] Turn off auto-suggestion in Android native password fields Before this patch:  After: 
|
The vulcan checks have successfully finished 30 mins ago, not sure why it still says "pending" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch:
After: