Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

[[ Bug 13085 ]] Add field equivalents of some paragraph properties #7195

Open
wants to merge 1 commit into
base: develop
Choose a base branch
Loading
from

Conversation

montegoulding
Copy link
Member

This patch makes leftIndent, rightIndent, spaceAbove and spaceBelow
which were previously only line chunk properties properties of fields similar
to firstIndent etc. This allows them to be set for all paragraphs in a
field at once rather than setting the properties on individual paragraphs.

This patch makes `leftIndent`, `rightIndent`, `spaceAbove` and `spaceBelow`
which were previously only line chunk properties properties of fields similar
to `firstIndent` etc. This allows them to be set for all paragraphs in a
field at once rather than setting the properties on individual paragraphs.
@montegoulding
Copy link
Member Author

Round trip to disk tests will merge up from this PR so we may want to merge that in and up before reviewing this. They pass locally though.

@trevordevore
Copy link
Contributor

@montegoulding and @runrevmark - When I saw this PR I thought of enhancement request #11934. Could an argument be made that the spaceAbove/spaceBelow of a paragraph should affect just the paragraph, and not every formatted line in the paragraph?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.