This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Blend Modes ]] Support more blend modes #6759
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runrevmark
reviewed
Oct 25, 2018
engine/src/tilecachecg.cpp
Outdated
| t_blend_mode = kCGBlendModeClear; | ||
| break; | ||
| case GXblendSrc: | ||
| case GXblendSrcOver: |
There was a problem hiding this comment.
GXblendSrcOver / GXcopy are BlendModeNormal - i.e. SrcOver
runrevmark
reviewed
Oct 25, 2018
engine/src/tilecachegl.cpp
Outdated
| case GXblendDst: | ||
| glBlendFunc(GL_ZERO, GL_ONE); | ||
| break; | ||
| case GXblendSrcOver: |
There was a problem hiding this comment.
These should be moved to the default case.
8f7fbb2 to
775ac83
Compare
775ac83 to
686adaf
Compare
|
@runrevmark do you think this should be rebased against develop? I was thinking it was reasonable for a maintenance release because it may resolve or at least document rendering issues in accelerated rendering under openGL |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.