Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

[[ Bug 21219 ]] selectedLine behavior tests #6498

Open
wants to merge 1 commit into
base: develop-9.0
Choose a base branch
Loading
from
Open

[[ Bug 21219 ]] selectedLine behavior tests #6498

wants to merge 1 commit into from

Conversation

montegoulding
Copy link
Member

This patch adds tests to compare the behavior of the selectedLine to
the behavior of an explicit line chunk.

@montegoulding montegoulding added this to the 9.0.1-rc-1 milestone Apr 22, 2018
montegoulding
montegoulding commented Apr 23, 2018
View reviewed changes
tests/lcs/core/field/selectedline.livecodescript
TestDiagnostic the clipboardData["text"]

__ResetField
select line 4 of field "Test"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is really testing how select chunk behaves.

montegoulding
montegoulding commented Apr 23, 2018
View reviewed changes
tests/lcs/core/field/selectedline.livecodescript
on TestCutSelectedLine
set the defaultStack to "Test"
__ResetField
cut line 4 of field "Test"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cut field chunk is not documented. Have opened a bug here https://quality.livecode.com/show_bug.cgi?id=21226

@montegoulding
Copy link
Member Author

montegoulding commented Apr 23, 2018 •
edited
Loading

Results for tests are:

FAIL:  tests/lcs/core/field/selectedline: TestCutSelectedLine [7/9]
not ok - select line then cut removes line
not ok - cut line includes line delimiter

FAIL:  tests/lcs/core/field/selectedline: TestCopySelectedLine [4/5]
not ok - select line and copy includes line delimiter

FAIL:  tests/lcs/core/field/selectedline: TestPasteSelectedLine [2/3]
not ok - select line and paste includes line delimiter

PASS:  tests/lcs/core/field/selectedline: TestDeleteSelectedLine [3/3]
FAIL:  tests/lcs/core/field/selectedline: TestHiddenPropertyOfSelectedLine [6/7]
not ok - hidden property of selectedLine is correct after

FAIL:  tests/lcs/core/field/selectedline: TestListStylePropertyOfSelectedLine [6/7]
not ok - listStyle property of selectedLine is correct after

FAIL:  tests/lcs/core/field/selectedline: TestPutIntoSelectedLine [2/3]
not ok - put into selectedLine replaces text of line

PASS:  tests/lcs/core/field/selectedline: TestPutBeforeSelectedLine [3/3]
FAIL:  tests/lcs/core/field/selectedline: TestPutAfterSelectedLine [2/3]
not ok - put after selectedLine inserts text after line

PASS:  tests/lcs/core/field/selectedline: TestSelectedLineRoundTrip [3/3]

@montegoulding
[[ Bug 21219 ]] selectedLine behavior tests
379b3e5 
This patch adds tests to compare the behavior of `the selectedLine` to
the behavior of an explicit line chunk.
@montegoulding
Copy link
Member Author

To summarise the results here:

  • select the selectedLine <> select line X of field because the selectedLine includes the trailing delimiter
  • put into/after and set property of the selectedLine <> put into/after and set property of line X of field because the selectedLine includes the trailing delimiter
  • delete, cut, copy seem to have been tweaked to account for this so in both cases the trailing delimiter is included.

@livecodepanos livecodepanos removed this from the 9.0.1-rc-1 milestone Aug 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug need-release-notes tests WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@montegoulding @livecodepanos
Morty Proxy This is a proxified and sanitized view of the page, visit original site.