This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ FontAwesome ]] Implement iconsvg library updater #5562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@montegoulding, thanks for your PR! By analyzing the history of the files in this pull request, we identified @livecodefraser to be a potential reviewer. |
|
https://stackoverflow.com/questions/18113478/extracting-svg-from-font-awesome So I need to write a little LCB library to transform the path instructions during the import. |
|
Alternatively have each path in the library have an isflipped attribute, and apply the transform in onpaint? Or, if this is the standard for svg fonts, maybe change the orientation used in the icon svg library? |
|
It could probably be a font family property if we were to do that but such a change would mean changing all the widgets using this library. |
This patch adds an updater script to the iconsvg library which imports glyphs from the FontAwesome svg file directly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an updater script to the iconsvg library which imports
glyphs from the FontAwesome svg file directly.
There is a problem with this in that the glyphs are flipped so leaving as WIP for now.
