This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 19474 ]] Make sure unnamed objects use id form #5530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@runrevmark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @livecodefraser and @livecodeali to be potential reviewers. |
|
Waiting on #5525 to be merged up. |
This patch ensures that when a script object requests the long name of an object, it uses the id form when an object is unnamed. The problem was caused by adding a new name mode (LONG_NAME_NO_FILENAME) but not testing for that when deciding what form of name to use for an unnamed object.
|
@livecode-vulcan review ok 7e45780 |
|
💙 review by @livecodeali ok 7e45780 |
|
😎 test success 7e45780
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that when a script object requests the long
name of an object, it uses the id form when an object is unnamed.
The problem was caused by adding a new name mode (LONG_NAME_NO_FILENAME)
but not testing for that when deciding what form of name to use for
an unnamed object.