@MicCalo, please rebase your branch, there are some merge conflict. But after resolving conflicts, branch doesn't build.

Ups, I wasn't aware that I'm on your repo but thought I'm on my fork :-)

Anyway, what do you think about this in general? Any inputs?

Ups, I wasn't aware that I'm on your repo but thought I'm on my fork :-)

I'll be glad to approve merge when you'll be ready.

Anyway, what do you think about this in general? Any inputs?

Implementation of the new CSS features is very appreciated. I've checked your changes. Here are some recommendations:

1. There are many changes in "spaces" - not big issue, but makes commit unclear.
2. I can recommend to add the m_counter_values into the litehtml::element instead of litehtml::html_tag. This will allow to get rid of std::dynamic_pointer_cast. As I saw std::dynamic_pointer_cast has issues with performance.
3. You are using std::map<string, int> m_counter_values. Is this possible replace strings with int using string_id technique?
4. If this is possible, create a test for counters

Thanks a lot for your thoughts. I have already moved the counter stuff upwards to litehtml::element which avoids the casts.

Now, I'm working on adding more functionality as I think the 'whole spec' except counter types could be implemented without bloating the code base.

Regarding the string_id approach, I'm not sure. The strings are not predefined but can be any content. Thus a map<string, string_id> would be needed anyway and this would only benefit memory usage when the page defines multiple counter with same name. Code size and complexity would increase.

I will definitely consider writing unit tests. I have to study your approach to see if it is possible.

Regarding the string_id approach, I'm not sure. The strings are not predefined but can be any content. Thus a map<string, string_id> would be needed anyway and this would only benefit memory usage when the page defines multiple counter with same name. Code size and complexity would increase.

Using _id(string) will give you ID for any string.

I will definitely consider writing unit tests. I have to study your approach to see if it is possible.

Creating tests for litehtml is easy. Just make one or some html files with counters, to cover all/most cases of counters using and place html files into the test/render directory. Then you can build and run tests. Inside litehtml directory:

mkdir build
cmake ../
make
ctest

During the first run all new tests will be FAILED, just find the file your_test_file.htm.FAILED.png, check if this PNG contains valid rendered page and rename it into your_test_file.htm.png. Now running ctest will show you that all tests are passed. Add to the git both htm and png files.

Idea of tests is simple: you have html file with test and png image with correct rendering of this html page. Test just render html file with changed code and compare two images. If images are differ - the test failed.

Alright, I would consider this done :-)

Added tests, used string-ids and reverted whitespace-only changes.

Please feel free to pull it directly or comment on it.

Merged. Thank you for new feature!