Fix: handle filenames with spaces in kernbench script #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! The change looks fine however there are spaces before tabs that should be fixed and the commit is missing signed-off-by line, see https://gerrit-review.googlesource.com/Documentation/user-signedoffby.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: handle filenames with spaces/newlines in kernbench source caching
This patch updates the loop used to cache the kernel source into RAM to handle filenames with spaces, newlines, and other special characters correctly.
Previously, the script used a
forloop over backtick-evaluatedfind, which would break on filenames with spaces or unusual characters. This caused warnings like:This patch replaces the loop with a more robust
find . -type f -print0 | while IFS= read -r -d ''structure, which safely handles all valid filenames.Signed-off-by: Sahil Kumar kumar.sgoyal@gmail.com