Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Filter regions based on account availabilities in get_regions function#625

Merged
zliang-akamai merged 5 commits intolinode:devlinode/linode_api4-python:devfrom
zliang-akamai:zhiwei/filter-regions-with-account-availabilitieszliang-akamai/linode_api4-python:zhiwei/filter-regions-with-account-availabilitiesCopy head branch name to clipboard
Jan 15, 2026
Merged

Filter regions based on account availabilities in get_regions function#625
zliang-akamai merged 5 commits intolinode:devlinode/linode_api4-python:devfrom
zliang-akamai:zhiwei/filter-regions-with-account-availabilitieszliang-akamai/linode_api4-python:zhiwei/filter-regions-with-account-availabilitiesCopy head branch name to clipboard

Conversation

@zliang-akamai
Copy link
Member

📝 Description

This may be helpful to reduce intermittent errors during integration tests.

✔️ How to Test

Run any test you like, for example:

python -m pytest test/integration/models/linode/test_linode.py -k test_get_linode -v

@zliang-akamai zliang-akamai marked this pull request as ready for review December 1, 2025 21:04
@zliang-akamai zliang-akamai requested a review from a team as a code owner December 1, 2025 21:04
@zliang-akamai zliang-akamai requested review from jriddle-linode and lgarber-akamai and removed request for a team December 1, 2025 21:04
@zliang-akamai zliang-akamai added the testing for updates to the testing suite in the changelog. label Dec 1, 2025
@zliang-akamai
Copy link
Member Author

Should be bypassed if the token doesn't have account API access. Converting to draft to work on it.

test/integration/conftest.py Outdated Show resolved Hide resolved
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the comment above, great work!

Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally, looks good!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the get_regions function to filter regions based on account-level availability constraints, helping to reduce intermittent errors during integration tests by ensuring selected regions have the necessary capabilities enabled for the account.

Key Changes:

  • Added account availability checking to filter regions based on account-specific capabilities
  • Added error handling with logging for cases where account availability retrieval fails

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/integration/conftest.py Outdated Show resolved Hide resolved
test/integration/conftest.py Outdated Show resolved Hide resolved
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/integration/conftest.py Outdated Show resolved Hide resolved
test/integration/conftest.py Outdated Show resolved Hide resolved
@lgarber-akamai lgarber-akamai requested a review from Copilot January 6, 2026 18:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/integration/conftest.py Show resolved Hide resolved
test/integration/conftest.py Show resolved Hide resolved
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@zliang-akamai zliang-akamai merged commit 43d8ec3 into linode:dev Jan 15, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing for updates to the testing suite in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.