Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Support Monitor Client and Fetch Entity Metrics#569

Merged
yec-akamai merged 8 commits intolinode:devlinode/linode_api4-python:devfrom
yec-akamai:monitor-clientyec-akamai/linode_api4-python:monitor-clientCopy head branch name to clipboard
Aug 11, 2025
Merged

Support Monitor Client and Fetch Entity Metrics#569
yec-akamai merged 8 commits intolinode:devlinode/linode_api4-python:devfrom
yec-akamai:monitor-clientyec-akamai/linode_api4-python:monitor-clientCopy head branch name to clipboard

Conversation

@yec-akamai
Copy link
Contributor

@yec-akamai yec-akamai commented Jul 10, 2025

📝 Description

This PR introduced a new client MonitorClient, to make calls to a different host monitor-api. Also refactor the LinodeClient and have them share a BaseClient. The endpoint for this client is fetching metrics for a list of entities. Also, updated test suite for the new client and test the fetching metrics endpoint.

✔️ How to Test

Unit test:

make test-unit

Integration test:

make test-int TEST_SUITE=monitor_api

linode_api4/groups/__init__.py Fixed Show fixed Hide fixed
linode_api4/objects/monitor_api.py Fixed Show fixed Hide fixed
test/unit/groups/monitor_api_test.py Fixed Show fixed Hide fixed
@yec-akamai yec-akamai changed the title init Support Monitor Client and Fetch Entity Metrics Jul 10, 2025
@yec-akamai yec-akamai marked this pull request as ready for review July 15, 2025 13:40
@yec-akamai yec-akamai requested a review from a team as a code owner July 15, 2025 13:40
@yec-akamai yec-akamai requested review from jriddle-linode and zliang-akamai and removed request for a team July 15, 2025 13:40
@yec-akamai yec-akamai added new-feature for new features in the changelog. do-not-merge PRs that should not be merged until the commented issue is resolved labels Jul 15, 2025
linode_api4/linode_client.py Show resolved Hide resolved
linode_api4/objects/monitor_api.py Show resolved Hide resolved
@yec-akamai yec-akamai removed the do-not-merge PRs that should not be merged until the commented issue is resolved label Jul 23, 2025
@yec-akamai yec-akamai requested a review from zliang-akamai July 23, 2025 19:40
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM working locally!

@yec-akamai yec-akamai merged commit 74e272a into linode:dev Aug 11, 2025
12 checks passed
@yec-akamai yec-akamai deleted the monitor-client branch August 11, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature for new features in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.