Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Enable include_none_values in FirewallSettingsDefaultFirewallIDs#558

Merged
zliang-akamai merged 2 commits intolinode:proj/enhanced-interfaceslinode/linode_api4-python:proj/enhanced-interfacesfrom
zliang-akamai:zhiwei/firewall-settings-include_none_valueszliang-akamai/linode_api4-python:zhiwei/firewall-settings-include_none_valuesCopy head branch name to clipboard
May 28, 2025
Merged

Enable include_none_values in FirewallSettingsDefaultFirewallIDs#558
zliang-akamai merged 2 commits intolinode:proj/enhanced-interfaceslinode/linode_api4-python:proj/enhanced-interfacesfrom
zliang-akamai:zhiwei/firewall-settings-include_none_valueszliang-akamai/linode_api4-python:zhiwei/firewall-settings-include_none_valuesCopy head branch name to clipboard

Conversation

@zliang-akamai
Copy link
Member

📝 Description

This is to enable include_none_values in FirewallSettingsDefaultFirewallIDs class to show null in the dict.

Needed by linode/ansible_linode#681

@zliang-akamai zliang-akamai requested a review from a team as a code owner May 28, 2025 07:47
@zliang-akamai zliang-akamai requested review from jriddle-linode and lgarber-akamai and removed request for a team May 28, 2025 07:47
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@ezilber-akamai ezilber-akamai self-requested a review May 28, 2025 19:49
@zliang-akamai zliang-akamai merged commit 06f8a5f into linode:proj/enhanced-interfaces May 28, 2025
12 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/firewall-settings-include_none_values branch May 28, 2025 20:16
@zliang-akamai zliang-akamai added the new-feature for new features in the changelog. label May 30, 2025
zliang-akamai added a commit that referenced this pull request Sep 22, 2025
* Enhanced Interfaces: Add support for Firewall templates (#529)

* Add support for Firewall Templates

* oops

* Add LA notices

* Enhanced Interfaces: Add account-related fields (#525)

* Enhanced Interfaces: Add account-related fields

* Add setting enum

* Add LA notice

* Drop residual print

* Enhanced Interfaces: Implement endpoints & fields related to VPCs and non-interface networking (#526)

* Implement endpoints & fields related to VPCs and non-interface networking

* Add LA notices

* Enhanced Interfaces: Add support for Linode-related endpoints and fields (#533)

* Add support for Linode-related endpoints and fields

* oops

* tiny fixes

* fix docsa

* Add docs examples

* Docs fixes

* oops

* Remove irrelevant test

* Add LA notices

* Fill in API documentation URLs

* Add return types

* Enable `include_none_values` in FirewallSettingsDefaultFirewallIDs (#558)

* Linode Interfaces: Allow specifying ExplicitNullValue for LinodeInterfaceOptions firewall ID (#565)

* Add ExplicitNullValue support

* Fix failing integration tests

* Add unit tests

* Add docs disclaimer

* Fix

* Update test/fixtures/linode_instances.json

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update test/unit/objects/linode_test.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update test/integration/conftest.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update linode_api4/objects/linode.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* More fixes

* lint

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Remove unnecessary local imports

* Fix IPv6 addresses

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update test/unit/objects/networking_test.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update test/unit/objects/linode_test.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com>
Co-authored-by: Lena Garber <lgarber@akamai.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lgarber-akamai added a commit that referenced this pull request Oct 7, 2025
* Enhanced Interfaces: Add support for Firewall templates (#529)

* Add support for Firewall Templates

* oops

* Add LA notices

* Enhanced Interfaces: Add account-related fields (#525)

* Enhanced Interfaces: Add account-related fields

* Add setting enum

* Add LA notice

* Drop residual print

* Enhanced Interfaces: Implement endpoints & fields related to VPCs and non-interface networking (#526)

* Implement endpoints & fields related to VPCs and non-interface networking

* Add LA notices

* Implement support for VPC Dual Stack (#524)

* Enhanced Interfaces: Add support for Linode-related endpoints and fields (#533)

* Add support for Linode-related endpoints and fields

* oops

* tiny fixes

* fix docsa

* Add docs examples

* Docs fixes

* oops

* Remove irrelevant test

* Add LA notices

* Fill in API documentation URLs

* Add return types

* Enable `include_none_values` in FirewallSettingsDefaultFirewallIDs (#558)

* VPC Dual Stack: Support changes related to Linode Interfaces (#559)

* Implementation; needs tests

* Add integration tests

* vpctest

* removeprint

* test

* Fix conflicts

* Fix missed conflict

---------

Co-authored-by: Zhiwei Liang <zliang@akamai.com>
Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com>
Co-authored-by: vshanthe <vshanthe@akamai.com>
Co-authored-by: Vinay <143587840+vshanthe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature for new features in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.