Added support for firewall rule version endpoints#520
Merged
ezilber-akamai merged 2 commits intolinode:devlinode/linode_api4-python:devfrom Mar 11, 2025
ezilber-akamai:TPT-3318-support-firewall-rule-version-endpointsezilber-akamai/linode_api4-python:TPT-3318-support-firewall-rule-version-endpointsCopy head branch name to clipboard
Merged
Added support for firewall rule version endpoints#520ezilber-akamai merged 2 commits intolinode:devlinode/linode_api4-python:devfrom ezilber-akamai:TPT-3318-support-firewall-rule-version-endpointsezilber-akamai/linode_api4-python:TPT-3318-support-firewall-rule-version-endpointsCopy head branch name to clipboard
ezilber-akamai merged 2 commits intolinode:devlinode/linode_api4-python:devfrom
ezilber-akamai:TPT-3318-support-firewall-rule-version-endpointsezilber-akamai/linode_api4-python:TPT-3318-support-firewall-rule-version-endpointsCopy head branch name to clipboard
Conversation
jriddle-linode
approved these changes
Mar 11, 2025
Collaborator
jriddle-linode
left a comment
There was a problem hiding this comment.
Looks good and works locally.
lgarber-akamai
approved these changes
Mar 11, 2025
Contributor
lgarber-akamai
left a comment
There was a problem hiding this comment.
Tests are passing on my end, nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added support for the GET /networking/firewalls/{firewallId}/history/rules/{version} and GET /networking/firewalls/{firewallId}/history endpoints, and relevant tests.
✔️ How to Test
The following steps assume you have pulled down this PR locally.
Unit Tests
make test-unitIntegration Tests
make test-int TEST_CASE=test_get_networking_rule_versions