Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

CI: Set token for security jobs in e2e test workflow#475

Merged
ykim-akamai merged 1 commit intolinode:devlinode/linode_api4-python:devfrom
ykim-akamai:test/fix_set_token_e2e_testsykim-akamai/linode_api4-python:test/fix_set_token_e2e_testsCopy head branch name to clipboard
Nov 13, 2024
Merged

CI: Set token for security jobs in e2e test workflow#475
ykim-akamai merged 1 commit intolinode:devlinode/linode_api4-python:devfrom
ykim-akamai:test/fix_set_token_e2e_testsykim-akamai/linode_api4-python:test/fix_set_token_e2e_testsCopy head branch name to clipboard

Conversation

@ykim-akamai
Copy link
Contributor

@ykim-akamai ykim-akamai commented Nov 13, 2024

📝 Description

Forgot to set token for the security jobs e.g. apply-calico-rules, add-fw-to-remaining-instances

✔️ How to Test

Passed on CLI repo which is using basically the same code: https://github.com/linode/linode-cli/actions/runs/11708470979
Forked run - https://github.com/ykim-akamai/linode_api4-python/actions/runs/11808463187 (Test failures are not related)

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai added the repo-ci-improvement for improvements in the repository or CI workflow in the changelog. label Nov 13, 2024
@ykim-akamai ykim-akamai requested a review from a team as a code owner November 13, 2024 00:47
@ykim-akamai ykim-akamai requested review from ezilber-akamai and zliang-akamai and removed request for a team November 13, 2024 00:47
@zliang-akamai
Copy link
Member

Is it possible to set the secrete via env: key in the workflow file rather than echoing it into the env var?

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykim-akamai ykim-akamai merged commit 96ac044 into linode:dev Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

repo-ci-improvement for improvements in the repository or CI workflow in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.