Appropriate formatting for __init__ file. #544
Merged
delucchi-cmu merged 7 commits intomainlincc-frameworks/python-project-template:mainfrom Oct 9, 2025
issue/542/rufflincc-frameworks/python-project-template:issue/542/ruffCopy head branch name to clipboard
Merged
Appropriate formatting for __init__ file. #544delucchi-cmu merged 7 commits intomainlincc-frameworks/python-project-template:mainfrom issue/542/rufflincc-frameworks/python-project-template:issue/542/ruffCopy head branch name to clipboard
delucchi-cmu merged 7 commits intomainlincc-frameworks/python-project-template:mainfrom
issue/542/rufflincc-frameworks/python-project-template:issue/542/ruffCopy head branch name to clipboard
Conversation
hombit
requested changes
Oct 9, 2025
Contributor
hombit
left a comment
There was a problem hiding this comment.
It works, thanks! Please do not change user's global git settings, even it tests, I believe this type of global changes should happen in CI, not in the test code.
drewoldag
approved these changes
Oct 9, 2025
Collaborator
drewoldag
left a comment
There was a problem hiding this comment.
This looks fine to me, I believe that it would address the issues that I ran into a few days ago with failing unit tests looking for __version__. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Closes #542
Closes #538
The initially hydrated
__init__.pyfile was not formatted toruffstandards, and so the initial pre-commit failed when choosing the ruff linting option (the default option).This PR makes an additional change to REALLY run the pre-commits in the unit tests. This catches all the checks that SHOULD be run, given the copier config that the project is hydrated with. The tests take quite a bit longer, but I think it's well worth it to catch such issues in the future.
Checklist
lincc-frameworks/python-project-templaterepo and not a downstream one instead.